https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4319 --- Comment #84 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- As referred to on IRC by Jonathan: === Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does exactly the same thing. So maybe "is_cancelable" is too specific? What could we do to keep this code simple, understandable and consistent? === I would personally not block this patch for that reason. We use IsItemOnHoldAndFound here to reduce yet more code to check the same; but this report is not about that sub. I would prefer to move the sub to Koha::Holds too, but that could well be done a its own report. If 4319 gets pushed and the other one follows, a new report can merge them. Just my thoughts. -- You are receiving this mail because: You are watching all bug changes.