[Bug 25375] New: Elasticsearch: Limit on available items does not work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Bug ID: 25375 Summary: Elasticsearch: Limit on available items does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: julian.maurice@biblibre.com Reporter: julian.maurice@biblibre.com Currently what this limit does is a filter on onloan:false This means that: - Any biblio with at least one checked out item will be hidden from the results, even if it has other available items - A biblio whose items are all lost, damaged, withdrawn or "notforloan" will not be hidden, but the results will show "X items, none available" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #1 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 104356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=104356&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 anne-cecile.bories@iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories@iepg.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #2 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm getting an error in the Elastic rebuild: root@287fd5fefa08:koha(master)$ perl misc/search_tools/rebuild_elasticsearch.pl -d -b Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 710. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #2)
I'm getting an error in the Elastic rebuild: root@287fd5fefa08:koha(master)$ perl misc/search_tools/rebuild_elasticsearch.pl -d -b Can't call method "items" on an undefined value at /kohadevbox/koha/Koha/SearchEngine/Elasticsearch.pm line 710.
MARC21 doesn't store the biblionumber in the 001 Should probably call GetMarcFromKohaField( 'biblio.biblionumber' ) to determine which field to use here I don't know if calling that for all the item fields may be more performant that fetching the biblio and iterating items as opposed to checking the MARC as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 109647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109647&action=edit Bug 25375: Get biblionumber from the correct MARC field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #104356|0 |1 is obsolete| | --- Comment #5 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 109659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109659&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109647|0 |1 is obsolete| | --- Comment #6 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 109660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109660&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109951&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109659|0 |1 is obsolete| | Attachment #109660|0 |1 is obsolete| | Attachment #109951|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109952&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109953&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 109954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109954&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- This works well, we should highlight the change in the release notes - in my testing nothing breaks, but we will need a full reindex for any ES site to make it work correctly. We will also need to highlight the new field for any sites using custom mapping files I added a followup - the performance doesn't seem to change greatly, but there is slight improvement on records with many items, and I think it is a bit simpler -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests are missing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25028 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Why not use "not-onloan-count" like for Zebra ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #14 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Giving this a bump as it continues to impact libraries. Julian, will you be able to revisit this? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 e.betemps <e.betemps@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |e.betemps@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109952|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 131310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131310&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109953|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 131311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131311&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109954|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 131312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131312&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 131313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131313&action=edit Bug 25375: Add tests for the "available" ES field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- Patches rebased, and tests added. Back to Signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131310|0 |1 is obsolete| | Attachment #131311|0 |1 is obsolete| | Attachment #131312|0 |1 is obsolete| | Attachment #131313|0 |1 is obsolete| | --- Comment #20 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132327&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #21 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132328&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #22 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132329&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 132330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132330&action=edit Bug 25375: Add tests for the "available" ES field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #24 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if 'not "notforloan"' should not only be for on order items that have not yet arrived at the library. As it is now we exclude all reference items as 'not available' which is not true usually. A lot of special libraries have large collections that are not for loan but can still be consulted. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #25 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Same for damaged - that something is damaged doesn't equal unavailable in a lot of libraries. It might just be so that when the item is checked out the patron is not blamed for pre-existing damage. Maybe we do need to have some configuration options here? If I could pick, I'd pick lost, withdrawn and on loan as unavailable. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #26 from Lisette Scheer <lisettepalouse+koha@gmail.com> --- (In reply to Katrin Fischer from comment #25)
Same for damaged - that something is damaged doesn't equal unavailable in a lot of libraries. It might just be so that when the item is checked out the patron is not blamed for pre-existing damage.
Maybe we do need to have some configuration options here?
If I could pick, I'd pick lost, withdrawn and on loan as unavailable.
I think it would be great if we had a pref like the OpacHiddenItems systems preference so each library could set it up. Lisette -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138800&action=edit Bug 25375: Match current Zebra availability limit -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #28 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #25)
Maybe we do need to have some configuration options here? If I could pick, I'd pick lost, withdrawn and on loan as unavailable.
Current behavior is wrong, can we agree to making it match Zebra behavior for a small improvement, then expand/fix on another bug? (In reply to Lisette Scheer from comment #26)
I think it would be great if we had a pref like the OpacHiddenItems systems preference so each library could set it up.
I filed bug 31304 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #29 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138802&action=edit Test records Import - checkout one of the items from 'one checked out' Search for 'bug 25375' to return all of these -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138800|0 |1 is obsolete| | --- Comment #30 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 138803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138803&action=edit Bug 25375: Match current Zebra availability limit In Zebra the availability limit code states: 'available' is defined as (items.onloan is NULL) and (items.itemlost = 0) We should make ES follow the same behaviour so that changing the engine does not change this. To test: 1 - Find or create several records with two items each 2 - For those records setup items as: a - one checked out, one available b - both marked lost c - both damaged d - both withdrawn e - both notforloan 3 - Enable ES and reindex to confirm everything is set 4 - Perform an advanced search to return those records and 'limit to available items' 5 - Confirm you see records b,c,d,e and records say '2 items, none available' 6 - Apply patch 7 - Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 8 - Perform an advanced search to return those records and 'limit to available items' 9 - Confirm you see records a,b,c,d and al but a say '2 items, none available' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch CC| |victor@tuxayo.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@iki.fi QA Contact| |joonas.kylmala@iki.fi -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Joonas Kylmälä <joonas.kylmala@iki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132327|0 |1 is obsolete| | Attachment #132328|0 |1 is obsolete| | Attachment #132329|0 |1 is obsolete| | Attachment #132330|0 |1 is obsolete| | Attachment #138803|0 |1 is obsolete| | --- Comment #31 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140053&action=edit Bug 25375: Fix 'available' facet in elasticsearch Add a new boolean ES field named 'available', which is true if at least one item is available, which means the item is not on loan, not "notforloan", not withdrawn, not lost and not damaged A full indexation is required Test plan: 1. Apply patch and run updatedatabase.pl 2. Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 3. Make sure you have some biblios whose items are all unavailable, some biblios whose items are all available, and some biblios with at least one item available and at least one item unavailable 4. Use the 'available' filter on both opac and intranet and make sure it works as expected. Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #32 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140054&action=edit Bug 25375: Get biblionumber from the correct MARC field Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #33 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140055&action=edit Bug 25375: (QA follow-up) Count available items rather than iterating Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #34 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140056&action=edit Bug 25375: Add tests for the "available" ES field Signed-off-by: Nick Clemens <nick@bywatersolutions.com> Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #35 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- Created attachment 140057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140057&action=edit Bug 25375: Match current Zebra availability limit In Zebra the availability limit code states: 'available' is defined as (items.onloan is NULL) and (items.itemlost = 0) We should make ES follow the same behaviour so that changing the engine does not change this. To test: 1 - Find or create several records with two items each 2 - For those records setup items as: a - one checked out, one available b - both marked lost c - both damaged d - both withdrawn e - both notforloan 3 - Enable ES and reindex to confirm everything is set 4 - Perform an advanced search to return those records and 'limit to available items' 5 - Confirm you see records b,c,d,e and records say '2 items, none available' 6 - Apply patch 7 - Run `misc/search_tools/rebuild_elasticsearch.pl -d -b` 8 - Perform an advanced search to return those records and 'limit to available items' 9 - Confirm you see records a,b,c,d and al but a say '2 items, none available' Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #36 from Joonas Kylmälä <joonas.kylmala@iki.fi> --- (In reply to Nick Clemens from comment #28)
(In reply to Katrin Fischer from comment #25)
Maybe we do need to have some configuration options here? If I could pick, I'd pick lost, withdrawn and on loan as unavailable.
Current behavior is wrong, can we agree to making it match Zebra behavior for a small improvement, then expand/fix on another bug?
I agree, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #37 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi all, tests are failing for me. Please review. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #38 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 140572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140572&action=edit Bug 25375: Adjust tests and test itemlost, not notforloan Previous commit correctly lists Zebra availability test, but was a bad edit. This fixes the availability test to use itemlost Additiionally, tests were written before limits were agreed. Adjusted for the current settings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140899&action=edit Bug 23735: New atomicupdate syntax Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 140900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140900&action=edit Bug 23735: Spelling fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #42 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 140979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140979&action=edit Bug 25375: Fix QueryBuilder.t tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Follow-up pushed to master, thanks for promptly addressing it, Julian! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|22.11.00 |22.11.00, 22.05.07 released in| | Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com --- Comment #44 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for upcoming 22.05.07 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=27973 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |arthur.suzuki@biblibre.com Version(s)|22.11.00, 22.05.07 |22.11.00, 22.05.07, released in| |21.11.14 --- Comment #45 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- applied to 21.11 for 21.11.14 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED --- Comment #46 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (21.05.x). Feel free to ask if it's needed. Nothing to document it seems, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9810 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Michelle Spinney <mspinney@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mspinney@clamsnet.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 --- Comment #47 from Jonathan Druart <jonathan.druart@gmail.com> --- This requires a full reindex, don't we need to reindex the bibliographic record if the holdability changed? Same for notforloan if modified at itemtype level. (In reply to Joonas Kylmälä from comment #35)
Created attachment 140057 [details] [review] Bug 25375: Match current Zebra availability limit
Do we really need that? On the bibliographic detail page, "Available" is only displayed if the item is actually available :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25375 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7012 [Bug 7012] Limit to available does not exclude in-transit items -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org