[Bug 31212] New: Datelastseen should be a datetime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Bug ID: 31212 Summary: Datelastseen should be a datetime Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org This field should be updated to be a datetime field and the interface adapted to display the full date and time to help librarians track items -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Michal Urban <michalurban177@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #1 from Michal Urban <michalurban177@gmail.com> --- Created attachment 138053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=138053&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #2 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Failing this one because although it does change the field from date to datetime, the time is not accurately recorded. In all of the tests I ran, it records datelastseen as always being at midnight - e.g. 07/25/2022 00:00 Examples of tests: - Check an item in - Manually edit the datelastseen in items editor - Initiate a manual transfer of the item to another library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andreas Roussos <a.roussos@dataly.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |a.roussos@dataly.gr --- Comment #3 from Andreas Roussos <a.roussos@dataly.gr> --- Hi Michal, I concur with Sally; your patch, as it stands, does not work 100%. However, fear not! The Community is here to help! ;-) Since you're changing a column definition in the DB, you may want to have a look at these guidelines: https://wiki.koha-community.org/wiki/Database_updates The gist of it is that when you alter the database schema, you need to accommodate for both a) new installations (which you did by modifying the installer's DB structure in installer/data/mysql/kohastructure.sql), *and* b) existing installations by means of creating an atomicupdate file. Also, since the DATETIME column will now be able to store the exact time the item was last seen down to the second, you'll have to ensure the timestamp is stored with the correct accuracy in the DB. Finally, don't forget the unit tests whenever you want to submit a patch, as they can help you find oversights in your submitted code. As usual, the details are in the Wiki: https://wiki.koha-community.org/wiki/Unit_Tests#Good_practices_for_running_t... I hope this helps! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 139510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139510&action=edit Bug 31212: Add Database update -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |michalurban177@gmail.com |ity.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Ann Flournoy <aflournoy@cityofkeller.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aflournoy@cityofkeller.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from David Nind <david@davidnind.com> --- Patch no longer applies: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 31212: Change datelastseen from date to datetime field Using index info to reconstruct a base tree... M C4/Items.pm M Koha/Schema/Result/Deleteditem.pm M Koha/Schema/Result/Item.pm M installer/data/mysql/kohastructure.sql M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt M koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt M koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/reports/itemslost.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/moredetail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Item.pm Auto-merging Koha/Schema/Result/Deleteditem.pm Auto-merging C4/Items.pm CONFLICT (content): Merge conflict in C4/Items.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #138053|0 |1 is obsolete| | --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142262&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #139510|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142263&action=edit Bug 31212: Add Database update -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #8 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 142264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142264&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Rebased for current master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142262|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 142282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142282&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142263|0 |1 is obsolete| | --- Comment #11 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 142283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142283&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142264|0 |1 is obsolete| | --- Comment #12 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 142284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142284&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Ann Flournoy <aflournoy@cityofkeller.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142282|0 |1 is obsolete| | --- Comment #13 from David Nind <david@davidnind.com> --- Created attachment 142286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142286&action=edit Bug 31212: Change datelastseen from date to datetime field This patch changes the datelastseen field to a datetime field for better time accuracy. It also fixes the interface in order to display datelastseen as a datetime field. To test: 1. Apply patch 2. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 3. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 4. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 5. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 6. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142283|0 |1 is obsolete| | --- Comment #14 from David Nind <david@davidnind.com> --- Created attachment 142287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142287&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142284|0 |1 is obsolete| | --- Comment #15 from David Nind <david@davidnind.com> --- Created attachment 142288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142288&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #16 from David Nind <david@davidnind.com> --- I've signed off, but then I read through Sally's comments (comment #2). For editing the date last seen in the item editor, I: - Changed the BKS framework for 952$r so that it displays in the editor with the dateaccessioned.pl plugin - Edited an item: saves date and time with 00:00 for the time - Without the daetaccessioned.pl plugin you have to enter the date and time including seconds, otherwise you get an error (edited item so no date, added date without time): "Invalid value passed, items.datelastseen=09/05/2022 expected type is datetime at /...." Can confirm that check in and manual transfer are working as expected (with the date time displayed correctly). Also, when you edit an item, the date last seen changes to the current date but with the time set as 00:00. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to David Nind from comment #16)
I've signed off, but then I read through Sally's comments (comment #2).
For editing the date last seen in the item editor, I: - Changed the BKS framework for 952$r so that it displays in the editor with the dateaccessioned.pl plugin - Edited an item: saves date and time with 00:00 for the time - Without the daetaccessioned.pl plugin you have to enter the date and time including seconds, otherwise you get an error (edited item so no date, added date without time): "Invalid value passed, items.datelastseen=09/05/2022 expected type is datetime at /...."
Can confirm that check in and manual transfer are working as expected (with the date time displayed correctly).
Also, when you edit an item, the date last seen changes to the current date but with the time set as 00:00.
Thanks for your testing David, I'll set this one to FQA and try to fix those problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #18 from Lucas Gass <lucas@bywatersolutions.com> ---
Also, when you edit an item, the date last seen changes to the current date but with the time set as 00:00.
Editing an item should not update the datelastseen. For me it doesn't update without this patchset and it should not with it either. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #19 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 143595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143595&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #20 from Lucas Gass <lucas@bywatersolutions.com> ---
- Changed the BKS framework for 952$r so that it displays in the editor with the dateaccessioned.pl plugin - Edited an item: saves date and time with 00:00 for the time - Without the daetaccessioned.pl plugin you have to enter the date and time including seconds, otherwise you get an error (edited item so no date, added date without time): "Invalid value passed, items.datelastseen=09/05/2022 expected type is datetime at /...."
I think this is a separate bug about how we handle dates when not using the dateaccessioned plugin. I have filed it as such: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32168 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Updated test plan: 1. Apply patch, updatedatabase, restart_all 2. Check out an item, look at the datelastseen and make sure it is correctly updated with the correct timestamp. 3. Check in an item, look at the datelastseen and make sure it is correctly updated with the correct timestamp. 4. Search the catalogue and select a biblio with at least one item. Confirm in the holdings table that every entry in the "Last Seen" column is in date-time format. 5. Navigate to "Items" in for that same biblio and check the item "History" section to have "Last Seen" in the correct format 6. Click "Edit" then "Edit Items" and confirm that the table has date-time format for the "Date Last Seen" Column entries 7. Edit one of the items to have lost status, then navigate to the Reports section, find "Items Lost", and search for the item with the barcode. Confirm the proper date-time format in the result. 8. Navigate to Tools, then Inventory, run inventory and confirm that the "Date Last Seen" column entries are in proper format 9. Update MARC frameworks to expose the datelastseen column in the editor, also turn on the dateaccessioned plugin. Make sure you can properly edit the datelastseen using the datepicker -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from David Nind <david@davidnind.com> --- Hi Lucas. I've re-tested, but I'm still having an issue with the date last seen updating to the current date when editing an item. If I edit an item, the date last seen field is now pre-populated with the current date (952$r setup to display in staff interface and date_accesioned plugin added). This isn't the case before the patch is applied - it is populated with the date originally recorded before editing. Everything else seems to be working as expected in the test plan. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32168 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142286|0 |1 is obsolete| | --- Comment #23 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146369&action=edit Bug 31212: Change datelastseen from date to datetime field -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142287|0 |1 is obsolete| | --- Comment #24 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146370&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142288|0 |1 is obsolete| | --- Comment #25 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146371&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143595|0 |1 is obsolete| | --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 146372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146372&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #27 from Lucas Gass <lucas@bywatersolutions.com> --- This patchset is again ready for testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|michalurban177@gmail.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146369|0 |1 is obsolete| | --- Comment #28 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 147664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147664&action=edit Bug 31212: Change datelastseen from date to datetime field Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146370|0 |1 is obsolete| | --- Comment #29 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 147665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147665&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146371|0 |1 is obsolete| | --- Comment #30 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 147666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147666&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146372|0 |1 is obsolete| | --- Comment #31 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 147667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147667&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #32 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Can you explain the changes in C4/Items.pm? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #33 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #32)
Can you explain the changes in C4/Items.pm?
I mean the ones from the first patch. This one is definitely not needed: + my $today = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 0 }); This one should not be needed either: + $datelastseen = output_pref({ str => $datelastseen, dateformat => 'iso', dateonly => 0 }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #34 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #33)
(In reply to Jonathan Druart from comment #32)
Can you explain the changes in C4/Items.pm?
I mean the ones from the first patch.
This one is definitely not needed: + my $today = output_pref({ dt => dt_from_string, dateformat => 'iso', dateonly => 0 });
This one should not be needed either: + $datelastseen = output_pref({ str => $datelastseen, dateformat => 'iso', dateonly => 0 });
I took over this bug from someone else, so I cannot explain those changes. However I can removed those unnecessary lines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #35 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 148939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=148939&action=edit Bug 31212: (follow-up) Remove unnessesary changes from Items.pm -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |kyle@bywatersolutions.com |y.org | CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #147664|0 |1 is obsolete| | Attachment #147665|0 |1 is obsolete| | Attachment #147666|0 |1 is obsolete| | Attachment #147667|0 |1 is obsolete| | Attachment #148939|0 |1 is obsolete| | --- Comment #36 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150378&action=edit Bug 31212: Change datelastseen from date to datetime field Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150379&action=edit Bug 31212: Add Database update Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #38 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150380&action=edit Bug 31212: Fix date_from_string and explicitly called output_pref subroutine Signed-off-by: Ann Flournoy <aflournoy@cityofkeller.com> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #39 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150381&action=edit Bug 31212: (follow-up) Fix datelastseen when returning item Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #40 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150382&action=edit Bug 31212: (follow-up) Remove unnessesary changes from Items.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #41 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 150383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=150383&action=edit Bug 31212: (QA follow-up) Fix unit test, remove unused imports Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #42 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Please avoid including schema file updates along with other changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #43 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #44 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151189&action=edit Bug 31212: Fix api/v1/items. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151189|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 151190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151190&action=edit Bug 31212: Fix api/v1/items.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #46 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Jonathan Druart from comment #45)
Created attachment 151190 [details] [review] Bug 31212: Fix api/v1/items.t
it should fix api/v1/biblios.t as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to master |Needs documenting --- Comment #47 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Enhancement with additional_work_needed flag active - not backporting to 22.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151190|0 |1 is obsolete| | --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 151194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151194&action=edit Bug 31212: Adjust item spec for last_seen_date This bug changed the column to a date-time and the spec gets adjusted as well. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 --- Comment #49 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This development introduced a small regression in which the item gets stored twice during the tests in t/db_dependent/Koha/SearchEngine/Indexer.t because it used to store a date a couple times, with no real changes to the object (i.e. dt_from_string->ymd) and now it always differs (i.e. the attribute is marked as dirty). Options: 1. Adjust the tests to this situation and add FIXME and file a new bug to deal with the fact 2. Fix it here Ideas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33739 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33739 [Bug 33739] ModItemTransfer triggers indexing twice -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/690 Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This moves the last seen release notes| |date in | |`items.datelastseen` from a | |date to a datetime, meaning | |that now not only the date, | |but also the time will be | |recorded. Component|Architecture, internals, |Cataloging |and plumbing | CC| |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org