[Bug 34717] New: Incorrect method call in addorderiso2709.pl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Bug ID: 34717 Summary: Incorrect method call in addorderiso2709.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org There is an incorrect method usage in the script where GetBudgetByCode is used instead of GetBudget. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155217&action=edit Bug 34717: Fix budget selection This patch replaces GetBudgetByCode with GetBudget to allow budget population to happen correctly Test plan: Needs to be tested using the file attached as it includes the field mappings Needs to be tested in KTD as the mappings match a budget created in the KTD sample data (sandboxes run on KTD so are suitable for this) 1) In system preferences, search for MarcFieldsToOrder 2) Paste the following into the syspref: price: 975$p quantity: 975$q budget_code: 975$h 3) Save the syspref 4) In Acquistions, choose a vendor and go into a basket 5) Click Add to basket 6) Select From a new file 7) Use the file attached to this bug 8) Click Upload file 9) At the bottom, click Stage for import 10) When the import is complete, click Add staged files to basket 11) Tick the box next to the record name 12) Observe that under fund, you are being asked to select a fund 13) Apply patch 14) restart_all 15) Refresh the page 16) Observe that the budget has now defaulted to Fund 1_2 as per the mappings in the marc file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155219&action=edit Test file with mapped fields -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #155217|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Created attachment 155220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155220&action=edit Bug 34717: Fix budget selection This patch replaces GetBudgetByCode with GetBudget to allow budget population to happen correctly Test plan: Needs to be tested using the file attached as it includes the field mappings Needs to be tested in KTD as the mappings match a budget created in the KTD sample data (sandboxes run on KTD so are suitable for this) 1) In system preferences, search for MarcFieldsToOrder 2) Paste the following into the syspref: price: 975$p quantity: 975$q budget_code: 975$h 3) Save the syspref 4) In Acquistions, choose a vendor and go into a basket 5) Click Add to basket 6) Select From a new file 7) Use the file attached to this bug 8) Click Upload file 9) At the bottom, click Stage for import 10) When the import is complete, click Add staged files to basket 11) Tick the box next to the record name 12) Observe that under fund, you are being asked to select a fund and the budget being mapped in the file has not been populated as it should be 13) Apply patch 14) restart_all 15) Refresh the page 16) Observe that the budget has now correctly defaulted to Fund 1_2 as per the mappings in the marc file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34717 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org