[Bug 40720] New: Misleading tooltip text "remove all items" in Select2 fields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Bug ID: 40720 Summary: Misleading tooltip text "remove all items" in Select2 fields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: elina.uotila@jarvenpaa.fi QA Contact: testopia@bugs.koha-community.org When editing an item record (for example, changing its current not for loan value) and hovering the cursor over the x symbol at the end of the field, Koha displays the tooltip text "remove all items". This wording is misleading, as the function does not remove any items from the database. Instead, it clears the selected value(s) in the drop-down menu. The affected text string comes from the messages-js.po file and is used by Select2 (koha-tmpl/intranet-tmpl/prog/js/select2.js:26). The fields where this text is used are all drop-down menus that are not directly related to items, so the wording "items" is confusing in this context. Would it be possible to change the phrase "remove all items" in Select2 to something more accurate, such as "remove selection"? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |slavashishkin@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Misleading tooltip text |Misleading title attribute |"remove all items" in |"Remove all items" in |Select2 fields |Select2 fields Version|unspecified |Main Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 188513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188513&action=edit Bug 40720: Misleading title attribute "Remove all items" in Select2 fields This patch updates our Select2 initialization script to update the strings used as title attributes on the "X" control which appears in a Select2 dropdown when you've made a selection. The updated text reads "Clear selections" in order to eliminate the ambiguity of the word "items." To test, apply the patch and clear your browser cache. - Go to Catalog -> Item search. - Make one or more selections in any of the Select2 dropdowns (e.g. Home library, current library, item type, etc.). - An "X" should appear at the end of the field after you've made one or more selections. - Hover your mouse over the "X." The title which appears should read "Clear selections." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188513|0 |1 is obsolete| | --- Comment #2 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 188518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188518&action=edit Bug 40720: Misleading title attribute "Remove all items" in Select2 fields This patch updates our Select2 initialization script to update the strings used as title attributes on the "X" control which appears in a Select2 dropdown when you've made a selection. The updated text reads "Clear selections" in order to eliminate the ambiguity of the word "items." To test, apply the patch and clear your browser cache. - Go to Catalog -> Item search. - Make one or more selections in any of the Select2 dropdowns (e.g. Home library, current library, item type, etc.). - An "X" should appear at the end of the field after you've made one or more selections. - Hover your mouse over the "X." The title which appears should read "Clear selections." Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Slava Shishkin <slavashishkin@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188518|0 |1 is obsolete| | --- Comment #3 from Slava Shishkin <slavashishkin@gmail.com> --- Created attachment 188519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188519&action=edit Bug 40720: Misleading title attribute "Remove all items" in Select2 fields This patch updates our Select2 initialization script to update the strings used as title attributes on the "X" control which appears in a Select2 dropdown when you've made a selection. The updated text reads "Clear selections" in order to eliminate the ambiguity of the word "items." To test, apply the patch and clear your browser cache. - Go to Catalog -> Item search. - Make one or more selections in any of the Select2 dropdowns (e.g. Home library, current library, item type, etc.). - An "X" should appear at the end of the field after you've made one or more selections. - Hover your mouse over the "X." The title which appears should read "Clear selections." Sponsored-by: Athens County Public Libraries Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #188519|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 188653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188653&action=edit Bug 40720: Misleading title attribute "Remove all items" in Select2 fields This patch updates our Select2 initialization script to update the strings used as title attributes on the "X" control which appears in a Select2 dropdown when you've made a selection. The updated text reads "Clear selections" in order to eliminate the ambiguity of the word "items." To test, apply the patch and clear your browser cache. - Go to Catalog -> Item search. - Make one or more selections in any of the Select2 dropdowns (e.g. Home library, current library, item type, etc.). - An "X" should appear at the end of the field after you've made one or more selections. - Hover your mouse over the "X." The title which appears should read "Clear selections." Sponsored-by: Athens County Public Libraries Signed-off-by: Slava Shishkin <slavashishkin@gmail.com> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Improvement: Updated release notes| |Select2 title text for | |clarity | | | |This patch updates the | |Select2 initialization | |script to improve | |accessibility and clarity. | |The title attribute on the | |“X” control (used to clear | |selections in Select2 | |dropdowns) now reads “Clear | |selections” instead of | |“Clear items,” eliminating | |ambiguity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Owen's authorship has been dropped here (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.06 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.06 |25.11.00,25.05.06,24.11.11 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40720 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to oldstable |Needs documenting --- Comment #9 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org