[Bug 19751] New: Holds awaiting pickup report should not be fixed-width
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Bug ID: 19751 Summary: Holds awaiting pickup report should not be fixed-width Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/circ/waitingreserves.pl OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 19700 The holds awaiting pickup report should not be fixed-width. The table can be very wide, especially with the width of "Cancel and return to..." buttons with long branch names. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700 [Bug 19700] Move template JavaScript to the footer: Some circulation pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 69510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69510&action=edit Bug 19751: Holds awaiting pickup report should not be fixed-width This patch changes the grid used for the holds awaiting pickup report so that the results are full page and fluid instead of fixed-width. To test, apply this patch and the patch for Bug 19700 if necessary. View the holds awaiting pickup report. The report should fluidly fill the page width. Test with the CircSidebar system preference enabled and disabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ByWaterSandboxes@gmail.com Status|Needs Signoff |Signed Off --- Comment #2 from ByWaterSandboxes@gmail.com --- Patch tested with a sandbox, by George Williams <george@nekls.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 ByWaterSandboxes@gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69510|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 --- Comment #3 from ByWaterSandboxes@gmail.com --- Created attachment 69512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69512&action=edit Bug 19751: Holds awaiting pickup report should not be fixed-width This patch changes the grid used for the holds awaiting pickup report so that the results are full page and fluid instead of fixed-width. To test, apply this patch and the patch for Bug 19700 if necessary. View the holds awaiting pickup report. The report should fluidly fill the page width. Test with the CircSidebar system preference enabled and disabled. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69512|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 69600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69600&action=edit Bug 19751: Holds awaiting pickup report should not be fixed-width This patch changes the grid used for the holds awaiting pickup report so that the results are full page and fluid instead of fixed-width. To test, apply this patch and the patch for Bug 19700 if necessary. View the holds awaiting pickup report. The report should fluidly fill the page width. Test with the CircSidebar system preference enabled and disabled. Signed-off-by: George Williams <george@nekls.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19700 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19700 [Bug 19700] Move template JavaScript to the footer: Some circulation pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Pushed to stable for 17.11.01, awesome work all! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19751 --- Comment #7 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in v17.05.07 This looks more bug than enhancement. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org