[Bug 42584] New: Allow extra elements on staff top navigation bar
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Bug ID: 42584 Summary: Allow extra elements on staff top navigation bar Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Adding elements via new location StaffMastHeadExtraContent in html customizationf of additional contents. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #1 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199029&action=edit Bug 42584: Define html customization location StaffMastHeadExtraContent Test plan: Run t/db_dependent/Koha/AdditionalContents.t Go to Tools/Html customizations. Add new. Check if this type is in the list under Staff items. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #2 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199030&action=edit Bug 42584: Add StaffMastHeadExtraContent to staff header Test plan: Add an AC entry. Fill with something simple like: <img src="/favicon.ico"/> Refresh staff page and verify that it is shown on the nav bar. Obviously, you can refine with additional css etc. (Or add a style tag via AC too.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42586 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199030|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199050&action=edit Bug 42584: Add StaffMastHeadExtraContent to staff header Test plan: Add an AC entry. Fill with something simple like: <img src="/favicon.ico"/> Refresh staff page and verify that it is shown on the nav bar. Obviously, you can refine with additional css etc. (Or add a style tag via AC too.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199051&action=edit Bug 42584: (follow-up) Change name to StaffNavbarExtraContent I think "StaffNavbarExtraContent" is a more user-friendly term. This follow-up also adds the corresponding entry to the include file which helps display hints for each customization location: "Show this content in the staff interface navbar, separate from the main navigation menu" Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- I hope that re-name makes sense! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Owen Leonard from comment #5)
I hope that re-name makes sense!
Sure. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199051|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 199071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199071&action=edit Bug 42584: (follow-up) Change name to StaffNavbarExtraContent I think "StaffNavbarExtraContent" is a more user-friendly term. This follow-up also adds the corresponding entry to the include file which helps display hints for each customization location: "Show this content in the staff interface navbar, separate from the main navigation menu" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199029|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199050|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199071|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199105&action=edit Bug 42584: Define html customization location StaffMastHeadExtraContent Test plan: Run t/db_dependent/Koha/AdditionalContents.t Go to Tools/Html customizations. Add new. Check if this type is in the list under Staff items. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199106&action=edit Bug 42584: Add StaffMastHeadExtraContent to staff header Test plan: Add an AC entry. Fill with something simple like: <img src="/favicon.ico"/> Refresh staff page and verify that it is shown on the nav bar. Obviously, you can refine with additional css etc. (Or add a style tag via AC too.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 199107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199107&action=edit Bug 42584: (follow-up) Change name to StaffNavbarExtraContent I think "StaffNavbarExtraContent" is a more user-friendly term. This follow-up also adds the corresponding entry to the include file which helps display hints for each customization location: "Show this content in the staff interface navbar, separate from the main navigation menu" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Laura.escamilla@bywatersolu | |tions.com QA Contact|testopia@bugs.koha-communit |Laura.escamilla@bywatersolu |y.org |tions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199105|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199106|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #199107|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #11 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 202521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202521&action=edit Bug 42584: Define html customization location StaffMastHeadExtraContent Test plan: Run t/db_dependent/Koha/AdditionalContents.t Go to Tools/Html customizations. Add new. Check if this type is in the list under Staff items. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #12 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 202522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202522&action=edit Bug 42584: Add StaffMastHeadExtraContent to staff header Test plan: Add an AC entry. Fill with something simple like: <img src="/favicon.ico"/> Refresh staff page and verify that it is shown on the nav bar. Obviously, you can refine with additional css etc. (Or add a style tag via AC too.) Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #13 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 202524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202524&action=edit Bug 42584: (follow-up) Change name to StaffNavbarExtraContent I think "StaffNavbarExtraContent" is a more user-friendly term. This follow-up also adds the corresponding entry to the include file which helps display hints for each customization location: "Show this content in the staff interface navbar, separate from the main navigation menu" Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Laura_Escamilla <laura.escamilla@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michael.skarupianski@gmail. | |com, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |pedro.amorim@openfifth.co.u | |k --- Comment #14 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Hi all, The navbar content filters by the staff user's home library (logged_in_user.branchcode) instead of the library they're logged in at. The module home page blocks (IntranetmainUserblock, StaffPatronsHome, StaffCataloguingHome, etc.) all use Branches.GetLoggedInBranchcode, which follows 'Set library', and since the navbar is shown on every page alongside those blocks it should likely behave the same way. To reproduce: 1) Go to http://localhost:8081/cgi-bin/koha/tools/additional-contents.pl?op=add_form&category=html_customizations 2) Add an entry with 'Display location' 'StaffNavbarExtraContent', 'Library' 'Midway', content MIDWAY. Save. 3) Add another one with 'Library' 'Centerville', content CENTERVILLE. Save. 4) Click the library name in the top right, then 'Set library', and pick 'Midway' 5) The navbar shows CENTERVILLE, but it should show MIDWAY 6) For comparison, do the same with 'IntranetmainUserblock' and go to http://localhost:8081/cgi-bin/koha/mainpage.pl. It correctly shows MIDWAY. Swapping 'logged_in_user.branchcode || default_branch' for 'Branches.GetLoggedInBranchcode' in header.inc should fix it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #15 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 207817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207817&action=edit Bug 42584: (QA follow-up) Fix library filter Test plan: Add a StaffNavbarExtraContent block. And restrict it to some library. Verify that the block only shows up when switching to that library. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42584 --- Comment #16 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Thanks everyone! Pushed to main for 26.11! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org