[Bug 6303] New: Display Organisation and Parent Organisation names when viewing a borrower of type organistaion
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Bug #: 6303 Summary: Display Organisation and Parent Organisation names when viewing a borrower of type organistaion Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Patrons AssignedTo: kyle.m.hall@gmail.com ReportedBy: srdjan@catalyst.net.nz QAContact: koha-bugs@lists.koha-community.org CC: gmcharlt@gmail.com Display in ‘member details & OPAC Org & Parent org names eg Room 1, Paeroa Central School – otherwise room 1 is meaningless -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|kyle.m.hall@gmail.com |srdjan@catalyst.net.nz --- Comment #1 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-05-06 04:39:35 UTC --- Created attachment 4047 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4047 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent CC| |katrin.fischer@bsz-bw.de Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-10 11:47:27 UTC --- Hi Srdjan, I see this bug has an attached patch - can you add some information about what this patch is supposed to do and how it can be tested? Thx! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 --- Comment #3 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-08-11 04:08:14 UTC --- To test: In case of a borrower of type "organistaion" (I), on circulation and member screens as well as opac screens, display full organisation name that is kept in "Other name". An example: If we had an organisation Surname: Room 1 Other name: Paeroa Central School it would display only "Room 1". With this patch it shold show "Room 1 (Paeroa Central School)" or similar. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4047|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 13:54:35 UTC --- Created attachment 4994 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4994 [SIGNED-OFF] Bug 6303: patron-title.inc to display properly title for borrowers of category_type 'I' Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - checked opac and borrower account screens - checked normal and organisation patrons -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-08-14 13:55:21 UTC --- Created attachment 4995 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4995 screenshot showing change -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain@biblibre.com Patch Status|Signed Off |Does not apply --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-07 14:22:52 UTC --- sorry but the patch does not apply anymore, and there are a lot of conflicts it seems: [SIGNED-OFF] Bug 6303: patron-title.inc to display properly title for borrowers of category_type 'I' Apply? [yn] y Applying: Bug 6303: patron-title.inc to display properly title for borrowers of category_type 'I' /home/paul/koha.dev/koha-community/.git/rebase-apply/patch:53: trailing whitespace. # 'showname' which is the alternate form the user's first name if /home/paul/koha.dev/koha-community/.git/rebase-apply/patch:437: trailing whitespace. # in template <TMPL_IF name="I"> => instutitional (A for Adult, C for children) /home/paul/koha.dev/koha-community/.git/rebase-apply/patch:438: trailing whitespace. $template->param( $data->{'categorycode'} => 1 ); /home/paul/koha.dev/koha-community/.git/rebase-apply/patch:466: space before tab in indent. BORROWER_INFO => [ $borrower ], /home/paul/koha.dev/koha-community/.git/rebase-apply/patch:510: trailing whitespace. error: patch failed: C4/Members.pm:352 error: C4/Members.pm: patch does not apply error: patch failed: circ/circulation.pl:631 error: circ/circulation.pl: patch does not apply error: koha-tmpl/intranet-tmpl/prog/en/modules/members/messaging.tt: does not exist in index error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt:19 error: koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt:201 error: koha-tmpl/intranet-tmpl/prog/en/modules/tools/viewlog.tt: patch does not apply error: members/messaging.pl: does not exist in index error: patch failed: members/moremember.pl:442 error: members/moremember.pl: patch does not apply error: patch failed: members/notices.pl:55 error: members/notices.pl: patch does not apply Patch failed at 0001 Bug 6303: patron-title.inc to display properly title for borrowers of category_type 'I' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4994|0 |1 is obsolete| | --- Comment #7 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-10-10 02:28:09 UTC --- Created attachment 5820 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5820 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5820|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-11 06:22:19 UTC --- Created attachment 5836 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5836 [SIGNED-OFF] Bug 6303: Display Organisation and Parent Organisation names when viewing a borrower of type organistaion Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as advertised, doesn't affect display for non-organisational patrons. Note: Display change in OPAC only affects the summary tab. It would be a little bit more consistent to make the name show the same on all tabs in OPAC patron account. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_6 |Rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-24 11:40:13 UTC --- Updating version : This ENH could be in Koha 3.8 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|Rel_3_8 |master --- Comment #10 from Paul Poulain <paul.poulain@biblibre.com> 2011-10-25 15:05:56 UTC --- Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Patch Status|Signed Off |Does not apply --- Comment #11 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-14 13:15:49 UTC --- This patch is already SIGNED but unfortunately does no longer apply. Please fix whitespace issues and rebase. /usr/share/koha/testclone/.git/rebase-apply/patch:56: trailing whitespace. # 'showname' which is the alternate form the user's first name if /usr/share/koha/testclone/.git/rebase-apply/patch:444: trailing whitespace. # in template <TMPL_IF name="I"> => instutitional (A for Adult, C for children) /usr/share/koha/testclone/.git/rebase-apply/patch:445: trailing whitespace. $template->param( $data->{'categorycode'} => 1 ); /usr/share/koha/testclone/.git/rebase-apply/patch:499: trailing whitespace. error: patch failed: circ/circulation.pl:629 error: circ/circulation.pl: patch does not apply error: patch failed: members/moremember.pl:439 error: members/moremember.pl: patch does not apply -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QAContact|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5836|0 |1 is obsolete| | --- Comment #12 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-14 23:22:32 UTC --- Created attachment 6308 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6308 patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off --- Comment #13 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-16 13:45:56 UTC --- Katrin, I compared the two diffs. It is just a minor rebase. Would you mind if I put your signoff back to this patch? In view of that I am setting status back to Signed. Feel free to undo if you disagree ;) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-16 13:47:14 UTC --- Hi Marcel, I trust your eye on this, if you want to pass it QA, please do. Thank you for asking. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Signed Off |Failed QA --- Comment #15 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-16 15:00:19 UTC --- Thanks for rebasing. Just found a few minor issues: warning: 4 lines add whitespace errors double line in opac-user.pl: patron_flagged => $borr->{flagged}, + Why do you add surname there, isn't it already in borrower_info? There a few places where you remove card number by the include patron-title, but patron-title does not bring back card number. Meaning we lose info here. Examples: circ-menu.inc, circulation.tt, moremember.tt, etc. (Look for card number) Could you please fix them too? Great! -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 --- Comment #16 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-16 15:14:58 UTC --- (In reply to comment #15)
There a few places where you remove card number by the include patron-title, but patron-title does not bring back card number. Meaning we lose info here. Examples: circ-menu.inc, circulation.tt, moremember.tt, etc. (Look for card number) Ignore this remark. It is present in patron-title!
-- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6308|0 |1 is obsolete| | --- Comment #17 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-16 23:49:41 UTC --- Created attachment 6322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6322 patch The doubled line came from a poor conflict resolution at rebasing, thanks for spotting -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Failed QA |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Does not apply --- Comment #18 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-17 07:57:26 UTC --- Lots of problems when applying this patch? The patron_flagged line still is double. 22 files changed now instead of 19. Did you start from a clean master or some other situation? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6322|0 |1 is obsolete| | --- Comment #19 from Srdjan Jankovic <srdjan@catalyst.net.nz> 2011-11-18 00:38:40 UTC --- Created attachment 6334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6334 patch Terribly sorry, that was an old patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Does not apply |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6334|0 |1 is obsolete| | --- Comment #20 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-21 08:29:59 UTC --- Created attachment 6366 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6366 Signed patch -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Passed QA Summary|Display Organisation and |Display Organisation and |Parent Organisation names |Parent Organisation names |when viewing a borrower of |when viewing a borrower of |type organistaion |type organisation --- Comment #21 from M. de Rooy <m.de.rooy@rijksmuseum.nl> 2011-11-21 08:32:37 UTC --- QA Comment The patch applies with 4 whitespace warnings. No further comments now. Code looks good. Mostly template changes. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |rel_3_8 Patch Status|Passed QA |Patch Pushed --- Comment #22 from Paul Poulain <paul.poulain@biblibre.com> 2011-11-24 10:40:33 UTC --- Small comment: in SQL, LEFT JOIN categories ON borrowers.categorycode=categories.categorycode can also be written LEFT JOIN categories USING(categorycode) when both fields have the same name and there can't be any ambiguity on the tables applicable (there can be some when multiple LEFT JOIN). I personnally prefer this syntax, that hilight more the field you join on. Patch pushed, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6303 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #23 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-30 06:50:10 UTC --- Note: Headings on patron account pages are not consistent in styling, this is not a problem introduced by this patch. The organisation name + other name is shown correctly on the first tab (summary). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org