[Bug 8323] New: User created lists not sorting properly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Priority: P5 - low Change sponsored?: --- Bug ID: 8323 Assignee: oleonard@myacpl.org Summary: User created lists not sorting properly Severity: trivial Classification: Unclassified OS: All Reporter: chrish@catalyst.net.nz Hardware: All Status: NEW Version: unspecified Component: OPAC Product: Koha Sorting by year in opac lists doesn't work due to trying to use biblioitems.publicationyear which is not mapped in the default MARC21 mapping. My patch passes through the sorting field and will change 'year' to 'copyrightdate' to instead sort by biblio.copyrightdate (marc 260$c). Patch incoming (have to get bug number first). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|oleonard@myacpl.org |chrish@catalyst.net.nz --- Comment #1 from Chris Hall <chrish@catalyst.net.nz> --- Created attachment 10530 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10530&action=edit Fixing year sorting of OPAC lists Patch attached to fix, will pass sort field through the the SQL and will change 'year' to 'copyrightdate'. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10530|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 10537 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10537&action=edit [SIGNED-OFF] bug 8323 fixing year sorting of a list Signed-off-by: Marc Veron <veron@veron.ch> Works as expected. Caveat: If you edit the list in Opac, change the sort and then klick 'Save', the List always is displayed in title order. This is du to the fact that save calls opac-shelves.pl?viewshelf=4 without the sort parameter (defaults to 'title'). If you go back to lists, choose the list from List name, the param is correct and the list displays in expected order. It took quite a time to track that down, I first thought that opac-shelves.pl was broken. However, current bug 8323 is not affected, signing off. Marc -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 --- Comment #3 from Marc Véron <veron@veron.ch> --- Opend a bug for wrong sort order just after editing (8324). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |paul.poulain@biblibre.com Version|unspecified |rel_3_8 --- Comment #4 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: * Having to do $sortfield eq 'year' ? 'copyrightdate' : $sortfield proves that there's something wrong in the parameters. It's not in the scope of this patch to fix this, but if you want to provide a follow-up to have 'copyrightdate' in $sortfield instead of year, you'll be welcomed ! Otherwise, tiny patch, passes QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8323 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.3 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org