https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Holds charges should be |Consider a link table for |accessible from Holds |accountlines to varying | |other Koha tables. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@openfifth.c |ity.org |o.uk Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #2 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186477&action=edit Bug 40817: Schema updates -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #4 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186479&action=edit Bug 40817: Add REST API support for hold-account line embedding This patch extends the REST API to support embedding debits in hold responses and linking holds in debit responses: API Schema Changes: - Add debits field to hold.yaml definition for embedding account lines - Add hold field to debit.yaml definition for embedding associated holds - Update holds.yaml and patrons_holds.yaml endpoints to support debits embedding Koha::Account::Debit.pm: - Add hold() method for API embedding support - Enable bidirectional API relationships between debits and holds These changes allow API clients to: - Retrieve holds with their associated charges in a single request - Access hold information from debit/charge records - Reduce API round trips by embedding related data - Support efficient financial reporting and hold management workflows -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #6 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186481&action=edit Bug 40817: Add comprehensive unit tests for hold-account line linking This patch adds comprehensive unit test coverage for the hold-account line linking functionality: t/db_dependent/Koha/Account/Line.t: - Test hold() method returns correct Koha::Hold/Koha::Old::Hold objects - Test handling of reserve_id and old_reserve_id fields - Test graceful handling of NULL and invalid references t/db_dependent/Koha/Hold.t: - Test debits() method returns correct Koha::Account::Debits collection - Test _move_to_old() account line migration functionality - Test proper linking of fees to holds during creation and lifecycle t/db_dependent/Koha/Old/Hold.t: - Test debits() method for historical holds - Test account line relationships for completed/cancelled holds t/db_dependent/Koha/Account.t: - Test add_debit() with hold_id parameter for current and old holds - Test automatic hold detection and field assignment - Test error handling for non-existent holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186476|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189610&action=edit Bug 40817: Update database for hold-account linking This patch adds database schema changes to support direct linking between holds and their associated account lines (fees/charges): * Add reserve_id and old_reserve_id columns to accountlines table * Add foreign key constraints with CASCADE/SET NULL behavior * Add indexes for performance on the new foreign key columns * Add atomic update script for safe database migration These schema changes enable: - Direct linking between current holds and their fees - Automatic migration of account line links when holds move to old_reserves - Proper referential integrity with cascading behavior Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186478|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189612&action=edit Bug 40817: Add Koha object methods for hold-account line linking This patch implements the core object methods to support direct linking between holds and their associated account lines: Koha::Account.pm: - Enhance add_debit() to accept hold_id parameter for linking fees to holds - Add automatic detection of current vs old holds for proper field assignment - Add graceful handling of non-existent holds Koha::Account::Line.pm: - Add hold() method to retrieve associated hold (current or old) - Support bidirectional navigation between account lines and holds Koha::Hold.pm: - Add debits() method to get all charges associated with the hold - Update charge_hold_fee() to link created fees to the hold - Enhance _move_to_old() to migrate account line relationships - Add hold_id parameter to fee creation calls Koha::Old::Hold.pm: - Add debits() method for accessing charges linked to old holds Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #186480|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 189614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=189614&action=edit Bug 40817: Add API tests for hold-debits embedding This patch adds comprehensive API tests to verify the new hold-debits embedding functionality: holds.t: - Test GET /holds with debits embedding returns correct structure - Test POST /holds response includes embedded debits when requested - Verify embedded debits contain expected account line data - Test embedding works with both successful and failed hold creation patrons_holds.t: - Test GET /patrons/{id}/holds with debits embedding - Verify patron-specific hold debits are correctly returned - Test embedding parameter validation and error handling - Ensure proper authorization and access control Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40769 [Bug 40769] Highlight hold fees when placing a hold from the staff interface -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189612|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #189614|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #14 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193202&action=edit Bug 40817: Update database for hold-account linking This patch adds database schema changes to support direct linking between holds and their associated account lines (fees/charges): * Add reserve_id and old_reserve_id columns to accountlines table * Add foreign key constraints with CASCADE/SET NULL behavior * Add indexes for performance on the new foreign key columns * Add atomic update script for safe database migration These schema changes enable: - Direct linking between current holds and their fees - Automatic migration of account line links when holds move to old_reserves - Proper referential integrity with cascading behavior Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #16 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193204&action=edit Bug 40817: Add Koha object methods for hold-account line linking This patch implements the core object methods to support direct linking between holds and their associated account lines: Koha::Account.pm: - Enhance add_debit() to accept hold_id parameter for linking fees to holds - Add automatic detection of current vs old holds for proper field assignment - Add graceful handling of non-existent holds Koha::Account::Line.pm: - Add hold() method to retrieve associated hold (current or old) - Support bidirectional navigation between account lines and holds Koha::Hold.pm: - Add debits() method to get all charges associated with the hold - Update charge_hold_fee() to link created fees to the hold - Enhance _move_to_old() to migrate account line relationships - Add hold_id parameter to fee creation calls Koha::Old::Hold.pm: - Add debits() method for accessing charges linked to old holds Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #18 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193206&action=edit Bug 40817: Add API tests for hold-debits embedding This patch adds comprehensive API tests to verify the new hold-debits embedding functionality: holds.t: - Test GET /holds with debits embedding returns correct structure - Test POST /holds response includes embedded debits when requested - Verify embedded debits contain expected account line data - Test embedding works with both successful and failed hold creation patrons_holds.t: - Test GET /patrons/{id}/holds with debits embedding - Verify patron-specific hold debits are correctly returned - Test embedding parameter validation and error handling - Ensure proper authorization and access control Signed-off-by: Jackie Usher <jackie.usher@westsussex.gov.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40817 --- Comment #20 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 193208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=193208&action=edit Bug 40817: Fix C3 MRO compilation errors in child classes Explicitly load parent classes before inheritance declarations to resolve C3 method resolution order errors that occurred during QA syntax checking. Modern::Perl enables C3 MRO by default, and the base pragma needs the parent class to be fully loaded before establishing inheritance. Adding explicit 'use Parent::Class;' statements before 'use base qw(Parent::Class);' ensures proper C3 linearization during compile-time checks. This resolves QA script failures while maintaining all existing functionality. -- You are receiving this mail because: You are watching all bug changes.