[Bug 21811] New: Add warning when order receive form is saved without entering 'quantity received'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Bug ID: 21811 Summary: Add warning when order receive form is saved without entering 'quantity received' Change sponsored?: --- Product: Koha Version: 16.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org A common mistake in training the acquisition module is that the 'quantity received' field is not changed before saving the order receive form. There is no warning or other indication, that this field is needed in order to make the receive happen. I think usability woudl be better with a visual clue or warning there. I am not sure if the field coudl be made mandatory. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=26081 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 107619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107619&action=edit Bug 21811: Add JS confirmation when receiving - at least 1 item to receive When receiving, the "receive items" form should not be submitted if no items are going to be received Test plan: Create an order, close the basket, receive some items On the "receive items" form, do not select item (if items are created when placing the order) and submit the form => You must get a JS alert that prevent the form to be submitted Select at least one item, submit again => Now it's submitted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Severity|enhancement |normal Version|16.11 |master CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala@helsinki.fi --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- *** Bug 26081 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Before this patch we were able to save, and (reading the code) some info were used to update the items' order (like price, datelastseen, etc.) What is the expected behaviour here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #3)
Before this patch we were able to save, and (reading the code) some info were used to update the items' order (like price, datelastseen, etc.)
What is the expected behaviour here?
I am not sure if that behaviour (changing the items when nothing was actually received) was correct at all. I cannot think of a use case right now where you'd want that at this point. I think this should not block this patch. Patch still applied - resetting status in hope to get some more feedback next week from people testing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- I get this error each time there is 1 item left to receive. Software error: Template process failed: undef error - The method Koha::Item->size is not covered by tests! Trace begun at /var/repositories/koha/Koha/Object.pm line 827 Koha::Object::AUTOLOAD('Koha::Item=HASH(0xb30e228)') called at /var/repositories/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt line 234 eval {...} at /var/repositories/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt line 234 eval {...} at /var/repositories/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt line 18 Template::Provider::__ANON__('Template::Context=HASH(0xabeb380)') called at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Document.pm line 163 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Document.pm line 161 Template::Document::process('Template::Document=HASH(0xb1a5fb0)', 'Template::Context=HASH(0xabeb380)') called at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Context.pm line 351 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Context.pm line 321 Template::Context::process('Template::Context=HASH(0xabeb380)', 'Template::Document=HASH(0xb1a5fb0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Service.pm line 94 eval {...} at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template/Service.pm line 91 Template::Service::process('Template::Service=HASH(0xa8433f0)', '/var/repositories/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt', 'HASH(0xb0bc8f0)') called at /usr/lib/x86_64-linux-gnu/perl5/5.20/Template.pm line 66 Template::process('Template=HASH(0xaba15d8)', '/var/repositories/koha/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt', 'HASH(0xb0bc8f0)', 'SCALAR(0x41ad5b0)') called at /var/repositories/koha/C4/Templates.pm line 122 C4::Templates::output('C4::Templates=HASH(0x88fcd30)') called at /var/repositories/koha/acqui/orderreceive.pl line 214 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 --- Comment #6 from Joonas Kylmälä <joonas.kylmala@helsinki.fi> --- (In reply to Séverine Queune from comment #5)
I get this error each time there is 1 item left to receive.
Software error: Template process failed: undef error - The method Koha::Item->size is not covered by tests!
hmm, this doesn't look to be related to the patch here. Have you done koha-plack --restart <instance> and do you have the latest koha master version? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That's another bug, I am finding it, sec! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- (In reply to Katrin Fischer from comment #7)
That's another bug, I am finding it, sec!
Oh yes, just found it ! Bz 26730 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We are missing the last follow-up patch from bug 23376. Adding a dependency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23376 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 [Bug 23376] Cleanup order receive page code -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #107619|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112055&action=edit Bug 21811: Add JS confirmation when receiving - at least 1 item to receive When receiving, the "receive items" form should not be submitted if no items are going to be received Test plan: Create an order, close the basket, receive some items On the "receive items" form, do not select item (if items are created when placing the order) and submit the form => You must get a JS alert that prevent the form to be submitted Select at least one item, submit again => Now it's submitted Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112055|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 112111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112111&action=edit Bug 21811: Add JS confirmation when receiving - at least 1 item to receive When receiving, the "receive items" form should not be submitted if no items are going to be received Test plan: Create an order, close the basket, receive some items On the "receive items" form, do not select item (if items are created when placing the order) and submit the form => You must get a JS alert that prevent the form to be submitted Select at least one item, submit again => Now it's submitted Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice fix, works as expected, no QA failures. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- missing dependencies for 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Bug 21811 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21811 Bug 21811 depends on bug 23376, which changed state. Bug 23376 Summary: Cleanup order receive page code https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23376 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org