[Bug 29526] New: Add 'Immediately delete holds history' button to patron privacy tab in opac
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Bug ID: 29526 Summary: Add 'Immediately delete holds history' button to patron privacy tab in opac Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Currently patrons have an option 'Immediate deletion' to remove/anonymise all checkout history. We should add a new button for immediately deleting holds history and rename the other to indicate it affects only checkout history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20936 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 George Williams (NEKLS) <george@nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george@nekls.org --- Comment #1 from George Williams (NEKLS) <george@nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29780 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 [Bug 29780] Add Koha::Old::Holds->anonymize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 128967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128967&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This works correctly. I have doubts about the buttons on the page and the layout. Any ideas are welcome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson@bedfordtx.g | |ov --- Comment #4 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- All the functionality of the buttons worked correctly. I think the layout of the buttons looks fine. Here are my observations from testing: 1. I had to enable the AnonymousPatron sys pref in order to make the test plan work. 2. I think the first sentence under the 'Immediate deletion' heading should be changed. The word 'your' is not needed and makes the sentence read awkwardly. Also I would change 'here' to 'below' since there are now three button options. I think this text would be more clear: Whatever privacy rule you choose, you can delete all your checkout and hold history immediately by clicking below. 3. Once you have cleared your holds history from the privacy tab and then go to the holds history tab it states that "You have never placed a hold from this library." That is not really true - the holds history either has never been kept or has been cleared. The Checkout history tab displays 'No data available in table' when there is no checkout history. Maybe the text on the Holds history tab should be the same or similar. 4. The pre-patch behavior with the single 'Immediate deletion' button includes the following text - Please note, the last person to return an item is tracked for the management of items returned damaged. This still needs to be included so that the patron is aware of it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128974&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Current status: Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 128982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128982&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks for testing Barbara!
2. I think the first sentence under the 'Immediate deletion' heading should be changed. The word 'your' is not needed and makes the sentence read awkwardly. Also I would change 'here' to 'below' since there are now three button options. I think this text would be more clear:
I addressed this in a follow-up, the wording should be clearer now.
3. Once you have cleared your holds history from the privacy tab and then go to the holds history tab it states that "You have never placed a hold from this library." That is not really true - the holds history either has never been kept or has been cleared. The Checkout history tab displays 'No data available in table' when there is no checkout history. Maybe the text on the Holds history tab should be the same or similar.
I provided a follow-up to change the text on opac-holdshistory.tt to be more truthful. It should say 'No data available' now if you have no holds history.
4. The pre-patch behavior with the single 'Immediate deletion' button includes the following text - Please note, the last person to return an item is tracked for the management of items returned damaged. This still needs to be included so that the patron is aware of it. This text has not been changed but in order to see it the StoreLastBorrower system preference must be turned on.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #8 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- I will test again tomorrow. One other thing I noticed - The tab on the left side with all the account options displays 'Your holds history.' But the buttons on the privacy page display as 'Your hold history.' One is plural and one is singular - should they match? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128967|0 |1 is obsolete| | --- Comment #9 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 129027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129027&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128974|0 |1 is obsolete| | --- Comment #10 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 129028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129028&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128982|0 |1 is obsolete| | --- Comment #11 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 129029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129029&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Barbara Johnson <barbara.johnson@bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Barbara Johnson <barbara.johnson@bedfordtx.gov> --- Everything worked, the wording has improved and the layout looks good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29843 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29843 [Bug 29843] Add ->anonymize and ->filter_by_anonymizable to Koha::Old::Checkouts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|20936 |29525 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 [Bug 20936] Holds history for patrons in OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 [Bug 29525] Privacy settings for patrons should also affect holds history -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29780 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29780 [Bug 29780] Add Koha::Old::Holds->anonymize -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129027|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130259&action=edit Bug 29526: Add a way for patrons to delete their hold history The same way we have a button to immediately delete the checkouts history in the OPAC, we should have a similar option for the holds history. This patch implements that. To test: 1. Have a patron with some old checkouts and old holds. 2. Have OPACPrivacy, OPACHoldsHistory and opacreadinghistory enabled. 3. Notice in the OPAC the patron has some old checkouts and holds. 4. Use the Privacy tab to clean checkouts => SUCCESS: They are still cleaned as before this patch 5. Try to clean the old holds => SUCCESS: They are cleaned! 6. Add some old checkouts and holds 7. Use the new 'All' button => SUCCESS: All cleaned 8. Sign off :-D Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129028|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130260&action=edit Bug 29526: (follow-up) Put delete buttons in HTML table Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #129029|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 130261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130261&action=edit Bug 29526: (follow-up) change wording on opac-holdshistory.tt when table is empty Signed-off-by: Barbara Johnson <barbara.johnson@bedfordtx.gov> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Great work, all works as expected. QA script is happy. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 --- Comment #17 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Bug 29526 depends on bug 29525, which changed state. Bug 29525 Summary: Privacy settings for patrons should also affect holds history https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29525 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29526 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org