[Bug 14110] New: Silence warnings t/00-load.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Bug ID: 14110 Summary: Silence warnings t/00-load.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris@bigballofwax.co.nz Reporter: mtompset@hotmail.com QA Contact: gmcharlt@gmail.com Noted: bug 8879 is an omnibus for the ./t errors. This cleanly catches all the errors in t/00-load.t, but it does not clean up the Koha tests which actually exclude testing Koha/NorwegianPatronDB.pm! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8879 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8879 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=8879 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 38751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38751&action=edit Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38751|0 |1 is obsolete| | --- Comment #2 from Indranil Das Gupta <indradg@gmail.com> --- Created attachment 39226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39226&action=edit Bug 14110: Silence t/00-load.t warnings prove t/00-load.t has noisy messages. This catches them. TEST PLAN --------- 1) $ prove -v t/00-load.t -- ugly INIT errors, etc. 2) apply patch 3) $ prove -v t/00-load.t -- nice "Expected warnings" type messages on the ones that were noisy. 4) koha qa test tools Signed-off-by: Indranil Das Gupta <indradg@gmail.com> Test remarks: Expected outcome as per test plan. No anomaly noted. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m Status|Signed Off |In Discussion --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- These warnings should not be hidden, we should fix them correctly. IMO this is not valid. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #3)
These warnings should not be hidden, we should fix them correctly. IMO this is not valid.
In which case, I would recommend three new bugs. I would recommend 4, but the hbbyy whatever it is barcode is deprecated. We should just catch that error, since there is no sense in fixing something declared deprecated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
In which case, I would recommend three new bugs. I would recommend 4, but the hbbyy whatever it is barcode is deprecated. We should just catch that error, since there is no sense in fixing something declared deprecated.
Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid choice for AutoBarcode. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Katrin Fischer from comment #5)
In which case, I would recommend three new bugs. I would recommend 4, but the hbbyy whatever it is barcode is deprecated. We should just catch that error, since there is no sense in fixing something declared deprecated.
Hm, why do you think it's deprecated? <branchcode>yymm0001 is still a valid choice for AutoBarcode.
perldoc C4/Barcodes/hbyymmincr.pm Comment from 2008 by Joe Atzberger. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Mark, I see... but I am not sure this is enough to deprecate as probably noone remembers it and no steps have been taken to remove the format from new installation or mark it as deprecated. I have my doubts about treating it as deprecated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14110 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=15239 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org