[Bug 14034] New: User logged out on refresh after Shibboleth authentication
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Bug ID: 14034 Summary: User logged out on refresh after Shibboleth authentication Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: chris@bigballofwax.co.nz, corinne.flacher-david@biblibre.com, dpavlin@rot13.org, fridolyn.somers@biblibre.com, jonathan.druart@biblibre.com, koha@univ-lyon3.fr, luce.barbey@cirad.fr, matthias.meusburger@biblibre.com, misilot@fit.edu, tomascohen@gmail.com Depends on: 12887 +++ This bug was initially created as a clone of Bug #12887 +++ The bug seems to also affect shibboleth.. I have no idea at what point it crept in or how.. but I've found the same on a recent update of one of our shibboleth customers. If you enable the _session_log you'll spot that every page request in fact results in an entirely new login taking place via shibboleth. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14035 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 42692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42692&action=edit Bug 14034: Fix logout on refresh for shibboleth This is similar to bug 12877 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This patch has been in live operation on at least four customers here since it was initially found.. I just hadn't had a chance to extract and submit it. Would be nice to get an external to PTFS-Europe signoff though. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42692|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 45961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45961&action=edit Bug 14034: Fix logout on refresh for shibboleth This is similar to bug 12877 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> While this is missing a detailed test plan, what I did to test was 1/ Login to koha .. it works 2/ Apply patch 3/ Login to koha .. it still works, no regressions. I can't test the shibboleth part but it doesnt break anything else so I'm happy to sign off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Matts, could you please test this patch and confirm that it works as expected? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Jesse Weaver <jweaver@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45961|0 |1 is obsolete| | --- Comment #5 from Jesse Weaver <jweaver@bywatersolutions.com> --- Created attachment 46162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46162&action=edit Bug 14034: Fix logout on refresh for shibboleth This is similar to bug 12877 Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> While this is missing a detailed test plan, what I did to test was 1/ Login to koha .. it works 2/ Apply patch 3/ Login to koha .. it still works, no regressions. I can't test the shibboleth part but it doesnt break anything else so I'm happy to sign off Signed-off-by: Jesse Weaver <jweaver@bywatersolutions.com> We had to implement this fix for one of our customers using Shibboleth. Can verify that it fixes the issue (which, incidentally, breaks stage-marc-import since that depends on a constant sessionID). Passing QA (verified with QA tools). Thanks, Martin! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14034 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org