[Bug 36816] New: OPAC - Patron 'submit update request' does not work for clearing patron attribute types
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Bug ID: 36816 Summary: OPAC - Patron 'submit update request' does not work for clearing patron attribute types Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: pedro.amorim@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, katrin.fischer@bsz-bw.de, kyle.m.hall@gmail.com, martin.renvoize@ptfs-europe.com, oleonard@myacpl.org, tomascohen@gmail.com 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, but is empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did not go through, i.e. the data is still there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart@gmail.com Depends on| |22844 Assignee|koha-bugs@lists.koha-commun |jonathan.druart@gmail.com |ity.org | --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Might be caused by commit 54cf5e897bc681aa06cefa0e062d21a24723b84b Bug 22844: Make the patron's attribute mandatory at the OPAC Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 [Bug 22844] Simplify the process of selecting database columns for system preferences -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35929 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Will write a fix on top of bug 35929 that is already signed off. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35929 [Bug 35929] Don't submit 'empty' changes to personal details in OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167008&action=edit Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 167009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167009&action=edit Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller@bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|christian.stelzenmueller@bs | |z-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167008|0 |1 is obsolete| | --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167042&action=edit Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167009|0 |1 is obsolete| | --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 167043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167043&action=edit Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167042|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167159&action=edit Bug 36816: Restore clearing patron attributes - OPAC 1) Add a new patron attribute type, visit: <staff_url>/cgi-bin/koha/admin/patron-attr-types.pl?op=add_attribute_type 2) Add a code and a description (whatever) - Make it 'Display in OPAC' and 'Editable in OPAC' 3) Access OPAC patron personal details page, visit: <opac_url>/cgi-bin/koha/opac-memberentry.pl 4) Scroll down and add some info to 'whatever'. Click 'Submit update request'. 5) Visit the INTRA 'update patron requests from opac' page: <staff_url>/cgi-bin/koha/members/members-update.pl 6) Notice the entry is there. Select 'approve' and click "Submit" 7) Repeat 3) 8) Scroll down and notice the approved value is there. Clear that data and "Submit update request" (as if you're requesting for that data to be removed/cleared) 9) Repeat 5) 10) Notice there's an entry, and it is not empty. Select 'approve' and click "Submit" 11) Repeat 3) 12) Scroll down and notice the request to update (clear) that field did go through, i.e. the data is not there anymore. Also test self-registration and mandatory attributes Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #167043|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 167160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167160&action=edit Bug 36816: Remove warning Use of uninitialized value in string eq at /kohadevbox/koha/opac/opac-memberentry.pl line 629. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.13 released in| | CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #11 from wainuiwitikapark@catalyst.net.nz --- Pushed to 23.05.x for 23.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Pushed to oldoldoldstable CC| |jesse@bywatersolutions.com --- Comment #12 from Jesse Maseto <jesse@bywatersolutions.com> --- This will be pushed to 22.11.x. for 22.11.25 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36816 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldoldstable |Needs documenting Version(s)|24.05.00,23.11.06,23.05.13 |24.05.00,23.11.06,23.05.13, released in| |22.11.25 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org