[Bug 41557] New: LoginFirstname, LoginSurname and emailaddress sent to template but never used
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Bug ID: 41557 Summary: LoginFirstname, LoginSurname and emailaddress sent to template but never used Initiative type: --- Sponsorship --- status: Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@gmail.com QA Contact: testopia@bugs.koha-community.org Bel Inconnu is actually no longer used 488 LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), 489 LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", 490 emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 191047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191047&action=edit Bug 41557: Remove unused vars sent to template 488 LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), 489 LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", 490 emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, Test plan: `git grep` the 3 variables and confirm that there is no occurrences in the templates (.tt/.inc files) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |aleisha@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 22264cc@hvhs.school.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 22264cc@hvhs.school.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191047|0 |1 is obsolete| | --- Comment #2 from 22264cc@hvhs.school.nz --- Created attachment 191829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191829&action=edit Bug 41557: Remove unused vars sent to template 488 LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), 489 LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", 490 emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, Test plan: `git grep` the 3 variables and confirm that there is no occurrences in the templates (.tt/.inc files) Signed-off-by: Connor Cameron-Jones <22264cc@hvhs.school.nz> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #191829|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 191839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=191839&action=edit Bug 41557: Remove unused vars sent to template 488 LoginFirstname => ( C4::Context->userenv ? C4::Context->userenv->{"firstname"} : "Bel" ), 489 LoginSurname => C4::Context->userenv ? C4::Context->userenv->{"surname"} : "Inconnu", 490 emailaddress => C4::Context->userenv ? C4::Context->userenv->{"emailaddress"} : undef, Test plan: `git grep` the 3 variables and confirm that there is no occurrences in the templates (.tt/.inc files) Signed-off-by: Connor Cameron-Jones <22264cc@hvhs.school.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |22264cc@hvhs.school.nz |ity.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |26.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00 |26.05.00,25.11.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 --- Comment #5 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41557 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Only dead code, lets skip backport to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org