[Bug 10840] New: Re-add missing [% OPACResultsSidebar %]
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Bug ID: 10840 Summary: Re-add missing [% OPACResultsSidebar %] Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResults Sidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 20845 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20845&action=edit Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- See the test plan in the first comment. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=10405 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20845|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 20991 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20991&action=edit Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20991|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20999 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20999&action=edit Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20999|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 21000 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21000&action=edit [PASSED QA] Bug 10840 - opac-facets.inc missing [% OPACResultsSidebar %] Bug 10405 rightly added id's to items, but inadvertently removed [% OPACResultsSidebar %] from the opac-facets.inc file. This bug rectifies that problem. Test Plan: Confirm the problem =================== 1) Using version 3.12.4 package installation, set OPACResultsSidebar system preference to some text. 2) In the OPAC, search for something 3) In the facets list on the left, the text should appear. 4) Using master installation, set OPACResultsSidebar system preference to some text. 5) In the OPAC, search for something 6) The facets will not have the text, though viewing the source, there is an empty <div id="opacresultssidebar">. Correct the problem =================== 1) Apply the patch to the master system 2) In the OPAC, search again for something 3) The facets on the left will now have the text showing similar to the 3.12.4 version Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Is back! OPACResultsSidebar is back! Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Copied test plan from bug report into commit message. Template only change, works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10840 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org