http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Darrell Ulm <darrellulm@smfpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent --- Comment #1 from Darrell Ulm <darrellulm@smfpl.org> 2010-10-07 19:16:58 UTC --- OK, Patch for new enhancement sent. Thanks! Darrell Ulm -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 --- Comment #3 from Darrell Ulm <darrellulm@smfpl.org> 2010-10-08 13:42:51 UTC --- (In reply to comment #2)

Darrell,

Where did you send the patch to? I don't see it on the public list or attached here.

Nicole

Hi Nicole. I sent it and tested my git send-email on my own account. It was sent to me. Is koha-patches@lists.koha-community.org receiving? Darrell -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 --- Comment #5 from Darrell Ulm <darrellulm@smfpl.org> 2010-10-08 14:32:44 UTC --- (In reply to comment #2)

Darrell,

Where did you send the patch to? I don't see it on the public list or attached here.

Nicole

Hi Nicole. I sent it and tested my git send-email on my own account. It was sent to me. Is koha-patches@lists.koha-community.org receiving? Darrell(In reply to comment #4)

I don't see any patches from you in the patches mailing list - is it possible that you're not registered with the list? I know that was the problem I had the first few patches I thought I sent - they weren't received cause I wasn't a registered user on the list.

Nicole, OK, well I had better register then. I guess a few patches have been missed. -Darrell -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> 2010-10-16 05:29:23 UTC --- Patch is here http://lists.koha-community.org/pipermail/koha-patches/2010-October/012666.h... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 --- Comment #10 from Nicole C. Engard <nengard@gmail.com> 2010-12-16 16:20:11 UTC --- The patch doesn't apply - and it also doesn't have a way to add the preference if you are upgrading (need to update updatedatabase.pl - unless I missed it) Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying Bug 5292 Google Preview Option for OPAC .dotest/patch:42: trailing whitespace. .dotest/patch:51: trailing whitespace. error: patch failed: installer/data/mysql/en/mandatory/sysprefs.sql:286 error: installer/data/mysql/en/mandatory/sysprefs.sql: patch does not apply Using index info to reconstruct a base tree... <stdin>:42: trailing whitespace. <stdin>:51: trailing whitespace. warning: 2 lines add whitespace errors. Falling back to patching base and 3-way merge... Auto-merged installer/data/mysql/en/mandatory/sysprefs.sql Auto-merged koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tmpl Auto-merged opac/opac-detail.pl nengard@debian:~/kohaclone$ -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 --- Comment #11 from Darrell Ulm <darrellulm@smfpl.org> 2010-12-16 16:34:56 UTC --- (In reply to comment #10)

The patch doesn't apply - and it also doesn't have a way to add the preference if you are upgrading (need to update updatedatabase.pl - unless I missed it)

Yes, I should re-base. I don't think it all got in there. Need to do this next year because of other responsibilities unfortunately. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2868|0 |1 is obsolete| | --- Comment #12 from Kyle M Hall <kyle.m.hall@gmail.com> --- Created attachment 10010 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10010&action=edit Bug 5292 - Google Preview Option for OPAC Adds option to insert link for Google Books preview into opac for items with available preview. Patch based on original work by Darrel Ulm. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Dobrica Pavlinusic <dpavlin@rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin@rot13.org --- Comment #13 from Dobrica Pavlinusic <dpavlin@rot13.org> --- Excuse my ignorance, but in current master we already have Google preview link when using google book covers. Why do we need another implementation of it? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5292 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low Status|RESOLVED |REOPENED Resolution|WORKSFORME |--- --- Comment #14 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #13)

Excuse my ignorance, but in current master we already have Google preview link when using google book covers. Why do we need another implementation of it?

The link we have now opens a new tab/window to the Google Books page. This patch tried to implement this feature for opening an embedded preview within the OPAC: https://developers.google.com/books/docs/preview-wizard -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.