[Bug 23608] New: Koha::Objects::Limit::Library->get_library_limits can return undef
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Bug ID: 23608 Summary: Koha::Objects::Limit::Library->get_library_limits can return undef Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org The get_library_limits routine within Koha::Objects::Limit::Library can return either a Koha::Libraries set or undef at present. As this is often part of a method chain we should drop the requirement to always check for undef in the return and instead ensure we return an unfiltered Koha::Libraries set which can be relied upon in subsequent method chaining. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 92801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92801&action=edit Bug 23608: Update return value of Koha::Object::Limit::Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Need to think about the UI a little here.. the 'All libraries' selection working in the inverse adds some fun. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I was going to open a bug for that, it leads to several warnings in categories.pl [WARN] Argument "" isn't numeric in numeric gt (>) at /kohadevbox/koha/koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt line 629. However my patch was simply doing: - return unless @branchcodes; + return Koha::Libraries->new->empty unless @branchcodes; -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17755 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17755 [Bug 17755] Introduce Koha::Patron::Attribute::Type(s) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wow... there's a lot of superfluous noise in my patch.. must have had a tidy setting on when I committed it. I do similar but instead of 'empty' I return 'all'.. shouldn't 'no limit' mean all rather than none.. or am I misunderstanding the function in the first place? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The POD says "It returns undef if no library limits defined." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- We actually return nothing in the first place to not selected anything on the admin edit form, for item type and categories: koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt: [% PROCESS options_for_libraries libraries => Branches.all( selected => category.get_library_limits, unfiltered => 1, do_not_select_my_library => 1 ) %] koha-tmpl/intranet-tmpl/prog/en/modules/admin/itemtypes.tt: [% PROCESS options_for_libraries libraries => Branches.all( selected => itemtype.get_library_limits, unfiltered => 1, do_not_select_my_library => 1 ) %] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (admin/credit_types.pl and admin/debit_types.pl should use the same construct by the way) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23608 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Is this still an issue? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org