[Bug 19073] New: Can't change library with patron batch modification tool
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Bug ID: 19073 Summary: Can't change library with patron batch modification tool Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org It appears that the option to change a users homebranch with the patron batch modification tool is broken. To test: - Install Koha sample patrons - Search all patrons (empty search) and add them to a patron list - Go to the patron batch modification tool - Select your list - Change branch to Centerville - Save - Verify Koha shows the result list, but that the branch hasn't been changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 --- Comment #1 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 65799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65799&action=edit Bug 19074: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65799|0 |1 is obsolete| | --- Comment #2 from Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> --- Created attachment 65801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65801&action=edit Bug 19073: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65801|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 65805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65805&action=edit [SIGNED OFF] Bug 19073: bugfix: Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated https://bugs.koha-community.org/show_bug.cgi?id=19073 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |alex.sassmannshausen@ptfs-e |ity.org |urope.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15758 --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Caused by: commit 9b9803b69c8bde879768ccfa3cc4688ef46b7799 Bug 15758: Koha::Libraries - Remove GetBranchesLoop Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 [Bug 15758] Move the C4::Branch related code to Koha::Libraries - part 4 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65805|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65841&action=edit Bug 19073: (bug 15758 follow-up) Dereference correct value from Koha::Object. * tools/modborrowers.pl: Dereference 'branchcode' rather than 'value'. Test Plan: - Carry out "Batch patron modification" with any number of patrons. + Change the library. + Hit Save. - The library will not have been updated. - Apply patch. - Run same modification. - The library will have been updated Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is a bad one, it affects 16.11.x and 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Bob Birchall <bob@calyx.net.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob@calyx.net.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.04. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.12. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #10 from Mason James <mtj@kohaaloha.com> --- Pushed to 16.05.x, for 16.05.17 release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19073 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 18792 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org