[Bug 22672] New: Replace <i> tags with <em> AND <b> tags with <strong> in the OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Bug ID: 22672 Summary: Replace <i> tags with <em> AND <b> tags with <strong> in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Since screen readers typically ignore <i> and <b> tags. Instead we should use <em> and <strong> tags which look the same visually but are more meaningful from an accessibility standpoint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley@catalyst.net.n | |z --- Comment #1 from Hayley Mapley <hayleymapley@catalyst.net.nz> --- Hi Lucas, You are listed as the assignee but the bug status is not Assigned. Do you need someone else to take this or did you just forget to change the status? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Thanks Hayley, I'll take it, I forgot to change the status. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |timothy_alexis.vass@ub.lu.s | |e Priority|P5 - low |P1 - high Severity|normal |critical --- Comment #3 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Changed to Importance: P1 - high / Critical as all 100+ library sites in Sweden are required to comply with something called Webbtillgänglighetsdirektivet (Web Accessibility Directive) by 23rd September 2020. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Lowering to major, sorry Timothy but that does not sound critical to me. Any news on this Lucas? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #5 from Lucas Gass <lucas@bywatersolutions.com> --- I will have a patch very soon. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 105405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105405&action=edit Bug 22672: Change <i> to <em> and <b> to <em> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/
Case not caugh by the grep: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt 298: [% IF ( ISSUE.onsite_checkout ) %] <i class="onsite_checkout">(On-site checkout)</i>[% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure what the best way to check would be, but can we rule out that these tags are used as selectors in Javascript/jQuery and or CSS? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #8)
I am not sure what the best way to check would be
To have someone fall into the rabbit hole. Soooooo, it's done ^^" There shouldn't be missing file types and cases from union of the 4 sections of the above report. (search for "==" to find them) The idea that lead to the greps was to - not risk letting cases unnoticed - don't have to learn non-trivial XML parsing and find how to run it on type-mixed files At the expense of letting noise (99.9% by font awesome and class="caret") through. And then check a lot of noise manually before sending the results above.
but can we rule out that these tags are used as selectors in Javascript/jQuery and or CSS?
I guess that's to be expected to have a few selectors vulnerable to that. Hmmm, would there be a way to search for them? Here comes another rabbit hole! :o -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #11 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
Replace <i> tags with <em> AND <b> tags with <strong> in the OPAC
in the OPAC
Oooooow, I missed that! Shall I create another ticket about the staff interface? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #12 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- It's definitely fine to replace <b> and <i> in both OPAC and STAFF. Is this ready to be implemented? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #13 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Timothy Alexis Vass from comment #12)
It's definitely fine to replace <b> and <i> in both OPAC and STAFF.
This can totally cause the whole thing to stop due to lack of time. Even if the OPAC part is almost done. Because the staff interface adds much more work and there are not the same strong requirements of accessibility as for the OPAC. So I'll split this ticket so the OPAC has a chance to move on.
Is this ready to be implemented?
Anyone that have some time for this can update the current patch add the missing case. I'll see if in the mess I've found there is something related to the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25744 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Here is another case in the OPAC koha-tmpl/opac-tmpl/xslt/OAI.xslt 146: <td><b>Repository Name</b></td> 151: <td><b>E-Mail Contact</b></td> 163: <td><b>Repository identifier</b></td> 169: <td><b>Sample identifier</b></td> 176: <td><b>Protocol Version</b></td> 184: <td><b>Earliest Registered Date</b></td> 192: <td><b>Date Granularity</b></td> 200: <td><b>Deletion Mode</b></td> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #15 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Findings not related to the OPAC have been moved to bug 25744. And comments here related to the OPAC have been marked as obsolete. Hopefully that will the work already done to move forward. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Katrin Fischer from comment #8)
I am not sure what the best way to check would be, but can we rule out that these tags are used as selectors in Javascript/jQuery and or CSS?
The number of pages is not that big. So would it be enough for the signoff to check every page to see if there is some obvious breakage? And more subtle stuff would be found in the rest of cycle. The benefit of being in the beginning of cycle :P Should be take into account that we should have during this cycle the migration of the OPAC to bootstrap 4? (bug 20168). Which would allow to catch any misplacement or mistyping that wasn't detected at the signoff. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #17 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- Created attachment 105870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105870&action=edit Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105405|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #18 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- - Searched the folders bootstrap and xslt with following regular expressions, to make sure: <b(\s.*)?> includes all <b> and <b ...> tags (?!.*fa)<i(\s.*.*)?> includes all <i> and <i ...> tags excluding any tags with font-awesome icons. - Found the same as Victor. - Added these changes and attached a new patch. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #19 from Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> --- I have looked through each occurence in each file and it's correct. There are only <strong> and <em> tags around text and it's all simple. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105870|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 106050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106050&action=edit Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #21 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Thanks Timothy for completing the patch :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #22 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Sorry, it does no longer apply. Can you rebase it? CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106050|0 |1 is obsolete| | --- Comment #23 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 106359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106359&action=edit Bug 22672: Change <i> to <em> and <b> to <strong> in templates, includes, xslt This patch attempts to replace <i> with <em> AND <b> with <strong> in order to more accessible to screen readers. This patch makes no attempt to change Font Awesome icons which typically use <i>. I found templates, includes and XSLT by using 'git grep ‘<b>’ koha-tmpl/opac-tmpl/bootstrap/en/' and git grep ‘<i>’ koha-tmpl/opac-tmpl/bootstrap/en/ TEST PLAN: There should be no visible difference on the changed pages. The files changed are: koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-note.inc koha-tmpl/opac-tmpl/bootstrap/en/modules/clubs/enroll.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth-MARCdetail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-authoritiessearchresultlist.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-browser.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-course-details.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-opensearch.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-overdrive-search.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-privacy.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results-grouped.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-review.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shareshelf.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl koha-tmpl/opac-tmpl/xslt/OAI.xslt Read the changes and make sure everything looks correct, try to visit as many pages as possible and confirm that everything looks as it should. grep around for cases of <b> or <i> that I could have missed. Signed-off-by: Timothy Alexis Vass <timothy_alexis.vass@ub.lu.se> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #24 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Conflict fixed. Double checked the diff of the file afterwards, no issues found. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 --- Comment #25 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|20.11.00 |20.11.00, 20.05.02 released in| | --- Comment #26 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz Status|Pushed to stable |Pushed to oldstable Version(s)|20.11.00, 20.05.02 |20.11.00, 20.05.02, released in| |19.11.08 --- Comment #27 from Aleisha Amohia <aleisha@catalyst.net.nz> --- backported to 19.11.x for 19.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable Version(s)|20.11.00, 20.05.02, |20.11.00, 20.05.02, released in|19.11.08 |19.11.08, 19.05.13 --- Comment #28 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported to 19.05.x branch for 19.05.13 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace <i> tags with <em> |Replace `i` tags with `em` |AND <b> tags with <strong> |AND `b` tags with `strong` |in the OPAC |in the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22672 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org