[Bug 40931] New: Hold pickup location drop-down boxes not wide enough when placing multiple holds at the same time.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Bug ID: 40931 Summary: Hold pickup location drop-down boxes not wide enough when placing multiple holds at the same time. Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: cj.lynce@westlakelibrary.org QA Contact: testopia@bugs.koha-community.org Created attachment 187221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187221&action=edit Example of hold pickup locations dropdown issue When placing a patron hold on multiple items at the same time, the width of the pickup location drop-down boxes are not wide enough to fully display the name of the pickup location. For short location names, only one letter is show. (see screenshot) This appears to have been introduced by bug 39533 in koha-tmpl/intranet-tmpl/prog/css/select2.css - '.select2.select2-container.select2-container--default' is set at 60%. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=40899 Depends on| |39533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39533 [Bug 39533] Use select2 to select item types and libraries in export of bibliographic records -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart@gmail.com> --- I didn't see your comment and I reached the same conclusion: This is fixed if I remove the css changes from bug 39533 koha-tmpl/intranet-tmpl/prog/css/select2.css .select2.select2-container.select2-container--default { flex-grow: 1; max-width: 60%; } fieldset.rows .select2 li { clear: none; width: unset; } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187454&action=edit Bug 40931: (bug 39533 follow-up) Isolate CSS changes to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to isolate the CSS changes so they will only affect the export page. Test plan: Confirm that this patch does not affect the display of the select2 elements from the export page. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #3 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Unfortunately this change impacts other items: for example, the item edit page has select2 boxes that now different sizes (see screenshot). This actually breaks what was fixed in bug_40897 (technically it now makes the select2 boxes shorter than the flatpickr boxes, which is opposite the original problem on that big) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #4 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187551&action=edit Example of item edit page select2 boxes after testing patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187454|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 187649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187649&action=edit Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to CJ Lynce from comment #3)
Unfortunately this change impacts other items: for example, the item edit page has select2 boxes that now different sizes (see screenshot). This actually breaks what was fixed in bug_40897 (technically it now makes the select2 boxes shorter than the flatpickr boxes, which is opposite the original problem on that big)
Good catch, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187649|0 |1 is obsolete| | --- Comment #7 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 187708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187708&action=edit Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from CJ Lynce <cj.lynce@westlakelibrary.org> --- This revised patch fixes the issue on the Multi-holds placement screen. It does not affect the select2 boxes on the item edit screen, and I checked a couple other places select2 is used, they are also unaffected. Thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #187708|0 |1 is obsolete| | --- Comment #9 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 188025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=188025&action=edit Bug 40931: (bug 39533 follow-up) More specific max-width CSS rule to prevent side-effects The changes made on bug 39533 for the export page have affected other instance of select2. eg. on the "place holds" view the select2 elements are too narrow. This patch suggests to reduce the elements on which the CSS rule 'max-width: 60%' is applied. Test plan: Confirm that this patch does not affect the display of the select2 elements on the export and item edition pages. Confirm that the pickup locations are wider (and their values are displayed) when placing multi holds Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 --- Comment #11 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40931 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Needs documenting --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 39533 not in 24.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org