[Bug 39915] New: Late issues export exports empty rows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Bug ID: 39915 Summary: Late issues export exports empty rows Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs@lists.koha-community.org Reporter: matt.blenkinsop@openfifth.co.uk QA Contact: testopia@bugs.koha-community.org To reproduce 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@openfifth.c |ity.org |o.uk -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |38829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38829 [Bug 38829] [CVE-2025-22954] SQL Injection in lateissues-export.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 --- Comment #1 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- This is caused by bug 38829 - we return before retrieving the issue if the supplier id is undefined which it always is because we don't pass it in the URL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 --- Comment #2 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182511&action=edit Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182511|0 |1 is obsolete| | --- Comment #3 from Matt Blenkinsop <matt.blenkinsop@openfifth.co.uk> --- Created attachment 182512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182512&action=edit Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182512|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182513&action=edit Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182513|0 |1 is obsolete| | --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 182514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182514&action=edit Bug 39915: Restore CSV export of late issues This patch restores the ability to export late serial claims to CSV Test plan: 1) Create a new subscription, setting the vendor id as 1 2) Set the subscription start date as yesterday's date, the other details aren't relevant so set whatever you want 3) Click into claims 4) If you get a warning saying no claims notice is defined then click the link to define one (on the dropdown for the 'New notice' button you want 'Claim serial issue. The content of the notice isn't relevant here so input anything). Then head back to the claims page. If no warning shows, proceed to the next step 5) Choose My Vendor and hit OK 6) You should see a table of claims with the first issue for your new serial 7) Click the checkbox next to the row 8) Click the 'Download selected claims' button at the bottom 9) The CSV will download 10) Click into it - it will have the header but the rows will be blank 11) Apply patch 12) Hard refresh the page 13) Click the download button again 14) Check the new file, the rows will be filled out correctly with data Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Paul Derscheid <paul.derscheid@lmscloud.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_11_candidate CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Late issues export exports |Late issues export exports |empty rows |empty rows in CSV -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.05.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 25.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.05.00 |25.05.00,24.11.05 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 24.11.x for 24.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_11_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39915 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz Status|Pushed to stable |Needs documenting --- Comment #8 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org