[Bug 11467] New: Untranslatable strings in opac-detail.tt
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Bug ID: 11467 Summary: Untranslatable strings in opac-detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Some strings in Javascript are not properly formatted for translation: $(".title").append('<a href="'+json.book.detail_link+'" id="idreambooksreadometer"><img src="http://idreambooks.com/remotereadometer/'+isbn+'.jpg" alt="'+json.book.title+' by '+json.book.author+'" title="Rating based on reviews of '+json.book.title+'"></a>'); $("#catalogue_detail_biblio").append("<span class='idreambookssummary results_summary'><a href='"+json.book.detail_link+"'><img src='"+json.book.to_read_or_not_small+"' alt='"+json.book.title+" by "+json.book.author+"' title='Rating based on reviews of "+json.book.title+"'>"+json.book.rating+"%</a> <a href='http://www.idreambooks.com/'>rating based on reviews at iDreamBooks.com</a></span>"); if (arrPagination[i].author) html += "<br /> by " + arrPagination[i].author; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39968 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39968&action=edit Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39968|0 |1 is obsolete| | --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 40251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40251&action=edit Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE) NOTE: Really should have read the test plan more closely. I couldn't find the 'Go to detail:' section, until I clicked 'Browse results'. Did not test additional language po files. Did trigger all code segments. http://bugs.koha-community.org/show_bug.cgi?id=11467 Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40251|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 40253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40253&action=edit Bug 11467: Bug Untranslatable srings in opac-detail.tt (IDreamBooks*, OpacBrowseResults) Patch marks several strings in the Javascript on the OPAC detail and result page for translation. 1) IDreamBooks* - Activate the 3 IDreamBooks* system preferences - Check the 'cloud' and additional content shows up correctly on the detail and result pages - Verify everything works as expected and the same as without the patch 2) OpacBrowseResults - Activate OpacBrowseResults - Do various searches - Verify the nex, previous, browse result list features still work the same as without the patch Bonus: Check new strings appear in the .po files by updating one language with the patch applied (perl translate update de-DE) NOTE: Really should have read the test plan more closely. I couldn't find the 'Go to detail:' section, until I clicked 'Browse results'. Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Maybe the format js function could have been used to permit a better translation in some languages. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, I forgot about that newer option. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #8 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, will be in 3.18.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11467 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Contains string changes, holding till 3.16.14 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org