[Bug 36337] New: Hiding lists with OpacPublic breaks styling for language list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Bug ID: 36337 Summary: Hiding lists with OpacPublic breaks styling for language list Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 33244 Added from the comment on bug 33244: Hello, [this patch] seems to have a side effect of the "Language" dropdown now being awkwardly placed on center-right (regardless of whether user is logged in our out). This is caused by the below CSS rules whose blame traces back to this patch, and removing them fixes the issue. #members { + flex-grow: 1; + justify-content: flex-end; Is this intentional change? I can only assume it's not, since I don't see any mention of this in the discussion. Screenshots of the problem: https://imgur.com/a/hDZvn7B It looks like this patch conditionally hides cart+lists. The CSS above then makes only language shown on the left, and the login on the right. But when things aren't hidden, it changes the original position. Should I create a new bug about this? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244 [Bug 33244] Do not show lists in OPAC if OpacPublic is disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 M <schodkowy.omegi-0r@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |schodkowy.omegi-0r@icloud.c | |om --- Comment #1 from M <schodkowy.omegi-0r@icloud.com> --- Thanks for creating the bug. To clarify though: the issue shows up when the lists are NOT hidden (which is the default). They added the feature of hiding lists and fixed the styling when they're hidden, but in turn broke the styling when they're normally shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 --- Comment #2 from M <schodkowy.omegi-0r@icloud.com> --- So I see three possible ways of fixing it: 1. Somehow making it so that while lists are shown, the languages are on the right as they were, and if hidden, on the left (will probably require adding a new CSS class to toggle the behavior, as I couldn't figure out any CSS trick for this) 2. Reverting and making it so that languages are always on the right, while nothing is shown on the left if lists are disabled 3. Make languages always on the left I wouldn't favor option #3 since that changes the UX and I think language belongs to the right next to user settings. In spirit of the original bug, I think they intended for #1 (to avoid keeping the space on left empty?). I personally think #2 might be the best? I mean there are many sites that have logo on the left and all toolbars on the right, it would look perfectly okay. I could try taking a stab at making a patch, but I'd welcome some opinions on the above I guess... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 168139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168139&action=edit Bug 36337: Hiding lists with OpacPublic breaks styling for language list This patch adjusts the CSS of elements in the OPAC header so that menu items are correctly aligned with various combinations of the OpacPublic and OpacLangSelectorMode system preferences. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - View the header menu in the OPAC with these combinations of settings: - OpacPublic = On; OpacLangSelectorMode = Top; - OpacPublic = On; OpacLangSelectorMode = Footer; - OpacPublic = Off; OpacLangSelectorMode = Top; - OpacPublic = Off; OpacLangSelectorMode = Footer; - With each configuration, test that the elements in the header (Logo, Cart/List menu, Language selctor, and user menu items) align correctly. The Cart/List menu items should always align to the left, the Language selector and user menu should aways align to the right. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168139|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 168186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168186&action=edit Bug 36337: Hiding lists with OpacPublic breaks styling for language list This patch adjusts the CSS of elements in the OPAC header so that menu items are correctly aligned with various combinations of the OpacPublic and OpacLangSelectorMode system preferences. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - View the header menu in the OPAC with these combinations of settings: - OpacPublic = On; OpacLangSelectorMode = Top; - OpacPublic = On; OpacLangSelectorMode = Footer; - OpacPublic = Off; OpacLangSelectorMode = Top; - OpacPublic = Off; OpacLangSelectorMode = Footer; - With each configuration, test that the elements in the header (Logo, Cart/List menu, Language selctor, and user menu items) align correctly. The Cart/List menu items should always align to the left, the Language selector and user menu should aways align to the right. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using KTD): 1. Need to have another language installed - see https://gitlab.com/koha-community/koha-testing-docker#translation-files . cd misc/translator/po . git fetch origin . git reset --hard origin/main . in the koha shell (ktd --shell), gulp po:update --lang fr-CA . exit from shell, and change to a root shell: ktd --root --shell . cd koha . koha-translate --install fr-CA --dev kohadev . restart_all 2. Enable the language for the OPAC: . OPACLanguages system preference - make sure languages are ticked . opaclanguagesdisplay system preference set to Allow 3. Regenerate the CSS: yarn build 4. Restart everything: restart_all -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37833 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37833 [Bug 37833] Incorrect logic controlling display of OPAC language selection menus -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Not sure if this is this patch that needs to fix it, but I found a bad display when en and en-GB are selected: https://snipboard.io/iBNjEn.jpg (bottom left) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |37841 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 [Bug 37841] Switch OPAC language menu alignment in header and footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #6)
Not sure if this is this patch that needs to fix it, but I found a bad display when en and en-GB are selected
Bug 37841 - Switch OPAC language menu alignment in header and footer -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168186|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171339&action=edit Bug 36337: Hiding lists with OpacPublic breaks styling for language list This patch adjusts the CSS of elements in the OPAC header so that menu items are correctly aligned with various combinations of the OpacPublic and OpacLangSelectorMode system preferences. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - View the header menu in the OPAC with these combinations of settings: - OpacPublic = On; OpacLangSelectorMode = Top; - OpacPublic = On; OpacLangSelectorMode = Footer; - OpacPublic = Off; OpacLangSelectorMode = Top; - OpacPublic = Off; OpacLangSelectorMode = Footer; - With each configuration, test that the elements in the header (Logo, Cart/List menu, Language selctor, and user menu items) align correctly. The Cart/List menu items should always align to the left, the Language selector and user menu should aways align to the right. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171339|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171357&action=edit Bug 36337: Hiding lists with OpacPublic breaks styling for language list This patch adjusts the CSS of elements in the OPAC header so that menu items are correctly aligned with various combinations of the OpacPublic and OpacLangSelectorMode system preferences. To test, apply the patch and rebuild the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff...) - View the header menu in the OPAC with these combinations of settings: - OpacPublic = On; OpacLangSelectorMode = Top; - OpacPublic = On; OpacLangSelectorMode = Footer; - OpacPublic = Off; OpacLangSelectorMode = Top; - OpacPublic = Off; OpacLangSelectorMode = Footer; - With each configuration, test that the elements in the header (Logo, Cart/List menu, Language selctor, and user menu items) align correctly. The Cart/List menu items should always align to the left, the Language selector and user menu should aways align to the right. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |jonathan.druart@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Bug 36337 depends on bug 37833, which changed state. Bug 37833 Summary: Incorrect logic controlling display of OPAC language selection menus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37833 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Bug 36337 depends on bug 37841, which changed state. Bug 37841 Summary: Switch OPAC language menu alignment in header and footer https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #11 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Missing dependencies for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 Bug 36337 depends on bug 33244, which changed state. Bug 33244 Summary: Do not show lists in OPAC if OpacPublic is disabled https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33244 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #12 from David Cook <dcook@prosentient.com.au> --- Looks like this is needed for 24.05 and 23.11 since bug 33244 caused the regression and they're both affected versions. But then this fix was done in a way that depends on bug 35402 which makes it impossible to backport? That's super frustrating... I suppose the short-term workaround is just to hide div#header_langmenu. I imagine 24.05 and 23.11 specific fixes could be worked out if it becomes necessary... -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org