[Bug 8009] New: Item descriptive data not populated on pay.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Priority: P5 - low Change sponsored?: --- Bug ID: 8009 CC: gmcharlt@gmail.com Assignee: paul.poulain@biblibre.com Summary: Item descriptive data not populated on pay.pl QA Contact: koha.sekjal@gmail.com Severity: trivial Classification: Unclassified OS: All Reporter: ruth@bywatersolutions.com Hardware: All Status: NEW Version: rel_3_8 Component: Staff Client Product: Koha On boraccount.pl, if an itemnumber is present in the accountline, the script passes ->{title} into the template for display (in GetMemberAccountRecords). The template for pay.pl tries to use a ->{title} entry in the same way to help populate the "Description" field, but GetBorNotifyAcctRecord doesn't create that, so only accountlines.description (if present) shows up. Patch coming shortly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain@biblibre.com |ruth@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 --- Comment #1 from D Ruth Bavousett <ruth@bywatersolutions.com> --- Created attachment 9295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9295&action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 D Ruth Bavousett <ruth@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9295|0 |1 is obsolete| | --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9535 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9535&action=edit Bug 8009: Item descriptive data not populated on pay.pl GetBorNotifyAcctRecord was not populating the {title} element of the hash, which pay.tt will use. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Version|rel_3_8 |master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA Comments: I don't find where is used the biblionumber, maybe it is useless. I think it is better to separate the description and the title, at least with a dot. I will propose a followup -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 9585 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9585&action=edit Bug 8009: Followup Item descriptive data not populated on pay.pl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9585|0 |1 is obsolete| | --- Comment #5 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Created attachment 9592 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9592&action=edit Bug 8009: Followup Item descriptive data not populated on pay.pl Separation of title from the description. Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Ian Walls <koha.sekjal@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Ian Walls <koha.sekjal@gmail.com> --- First patch just adds new params to export; marking Passed QA Second patch is just a set of () in a template... passed QA as well -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |paul.poulain@biblibre.com Version|master |rel_3_10 Severity|trivial |enhancement --- Comment #7 from Paul Poulain <paul.poulain@biblibre.com> --- more an ENH than a fix I think -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 --- Comment #8 from D Ruth Bavousett <ruth@bywatersolutions.com> --- Fix or enhancement, I'd really like to see it in Stable, if that's possible. We've got several libraries that are asking for it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_10 |rel_3_8 Severity|enhancement |minor --- Comment #9 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- I would consider this a bugfix. I intend to backport to 3.6.x, as it is a low-risk patch that fixes an obvious error. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Susie Hastings <hastingssf@vmi.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hastingssf@vmi.edu --- Comment #10 from Susie Hastings <hastingssf@vmi.edu> --- Just weighing in on this issue, “from the field” (Preston Library at VMI). We’re an academic library whose faculty have a loan period of a whole academic year. All their books are due on April 15, and when they are not returned after 28 days, they all become “Billed”. It would not be too unusual for a faculty member to want to pay for one item from a list of other billed items that he expects to return in a few days. You can imagine in that case how hard it would be to receive payment for the correct item, since there is no description on the “Pay Fines” tab. So, to me, this seems more like a fix than an enhancement, and it would be great to have it fixed as soon as possible. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8009 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #11 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x .. I will personally ring everyone of you if anyone complains about it being in 3.8.2 :-) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org