[Bug 30279] New: Log when personal data is displayed in staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Bug ID: 30279 Summary: Log when personal data is displayed in staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: glasklas@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The patch allows logging every access to patron personal data by staff members. This enables tracking of abnormal usage patterns in order to discover and mitigate possible data breaches, and the data collected could also be useful for investigators if such an event where to occur. An entry is written to the actions_log table when any page the patron-info sidebar is displayed on is viewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #1 from David Gustafsson <glasklas@gmail.com> --- Created attachment 131589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131589&action=edit Bug 30279: Log viewing of personal data in staff client Add possiblilty to log when personal data is viewed by staff in the web interface. To test: 1) Enable the system preference "PatronViewLog" 2) Visit any page where the patron-info sidebar is displayed 3) Verify that an log entry has been created for module "MEMBERS" and action "VIEW" in the action_logs table 4) Disable the system preference and perform step 2) again 5) Verify that no new log entries for the above module and action has been created Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131589|0 |1 is obsolete| | --- Comment #2 from David Gustafsson <glasklas@gmail.com> --- Created attachment 131590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131590&action=edit Bug 30279: Log viewing of personal data in staff client Add possiblilty to log when personal data is viewed by staff in the web interface. To test: 1) Enable the system preference "PatronViewLog" 2) Visit any page where the patron-info sidebar is displayed 3) Verify that an log entry has been created for module "MEMBERS" and action "VIEW" in the action_logs table 4) Disable the system preference and perform step 2) again 5) Verify that no new log entries for the above module and action has been created Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- A couple things to note here: 1. On viewlog.tt PatronViewLog should probably have it's own checkbox under 'Modules' so you can search the logs for that specifically. 2. The act of checking out an item puts several entry's into the logs. If I land on the patrons detail page (1 log), move to the Check out page ( 2nd log ), check something out ( 3rd log ), and so on. That seems like a lot of logging. 3. QA tool is complaining about missing filters: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc FAIL filters missing_filter at line 6 ([% ViewLog.log_patron_view(patron.borrowernumber) %]) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |glasklas@gmail.com |ity.org | Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Lucas Gass from comment #3)
A couple things to note here:
1. On viewlog.tt PatronViewLog should probably have it's own checkbox under 'Modules' so you can search the logs for that specifically.
2. The act of checking out an item puts several entry's into the logs. If I land on the patrons detail page (1 log), move to the Check out page ( 2nd log ), check something out ( 3rd log ), and so on. That seems like a lot of logging.
3. QA tool is complaining about missing filters:
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc FAIL filters missing_filter at line 6 ([% ViewLog.log_patron_view(patron.borrowernumber) %])
1 and 2 are just my thoughts, but I will set this to FQA because of 3, the missing filter. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Ola Andersson <ola.andersson@ltu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion CC| |ola.andersson@ltu.se --- Comment #5 from Ola Andersson <ola.andersson@ltu.se> --- (In reply to Lucas Gass from comment #4)
(In reply to Lucas Gass from comment #3)
A couple things to note here:
1. On viewlog.tt PatronViewLog should probably have it's own checkbox under 'Modules' so you can search the logs for that specifically.
2. The act of checking out an item puts several entry's into the logs. If I land on the patrons detail page (1 log), move to the Check out page ( 2nd log ), check something out ( 3rd log ), and so on. That seems like a lot of logging.
3. QA tool is complaining about missing filters:
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc FAIL filters missing_filter at line 6 ([% ViewLog.log_patron_view(patron.borrowernumber) %])
1 and 2 are just my thoughts, but I will set this to FQA because of 3, the missing filter.
As a response to point 2: I took part in the initial design and background to this feature that looked for an efficient way to log every page rendering in Koha that exposed patron information - this is achieved in a simple yet powerful way by this Gothenburg implementation. The idea is that you should be able to tell when patron information has been exposed within the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #6 from David Gustafsson <glasklas@gmail.com> --- Created attachment 131653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131653&action=edit Bug 30279: Add view action to system log page and fix QA tool issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #7 from David Gustafsson <glasklas@gmail.com> --- Thank you for the feedback/review. The filter issue should (hopefully) now be fixed. The method called in the template does not return anything and a filter makes no sense, but it should be resolved by using the CALL directive which does not expect a return value. Also added the new action on the page for browsing action-logs. Regarding excessive logging it's simply part of the spec of this feature as Ola pointed out. As logging of patron views is disabled by default and has to be enabled I assume those who enable it are aware that a new log entry will be created each time the patron info is shown. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune@bulac.fr --- Comment #8 from Séverine Queune <severine.queune@bulac.fr> --- Hi David, I get this error message trying to apply the patch on a devbox : Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 30279: Log viewing of personal data in staff client Using index info to reconstruct a base tree... M installer/data/mysql/mandatory/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/logs.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc Auto-merging installer/data/mysql/mandatory/sysprefs.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 30279: Log viewing of personal data in staff client hint: Use 'git am --show-current-patch=diff' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-30279-Log-viewing-of-personal-data-in-staff-cl-iw9yB4.patch I'll be happy to test it when it's fixed ! Séverine -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131590|0 |1 is obsolete| | --- Comment #9 from David Gustafsson <glasklas@gmail.com> --- Created attachment 132604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132604&action=edit Bug 30279: Log viewing of personal data in staff client Add possiblilty to log when personal data is viewed by staff in the web interface. To test: 1) Enable the system preference "PatronViewLog" 2) Visit any page where the patron-info sidebar is displayed 3) Verify that an log entry has been created for module "MEMBERS" and action "VIEW" in the action_logs table 4) Disable the system preference and perform step 2) again 5) Verify that no new log entries for the above module and action has been created Sponsored-by: Gothenburg University Library -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131653|0 |1 is obsolete| | --- Comment #10 from David Gustafsson <glasklas@gmail.com> --- Created attachment 132605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132605&action=edit Bug 30279: Add view action to system log page and fix QA tool issue -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 David Gustafsson <glasklas@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #11 from David Gustafsson <glasklas@gmail.com> --- Thanks. Rebased against master so conflicts should now be resolved. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Nice useful feature ! I noticed that the name of the module is 'Patrons' and not 'MEMBERS' as written in test plan. 2 logs are created when I search a patron using the main search box, whatever the tab I use (check out or search patron). It doesn't happen when you use the search form. I wonder if it should create log if HidePersonalPatronDetailOnCirculation is enabled : in that case, none of the personal datas are display out of the 'moremember.pl' page. Maybe this point is out of purpose, but we've got many other ways to access user's personal datas for example in the different search results or the hold pop-up. Shouldn't this be logged too ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #13 from Lucas Gass <lucas@bywatersolutions.com> ---
Maybe this point is out of purpose, but we've got many other ways to access user's personal datas for example in the different search results or the hold pop-up. Shouldn't this be logged too ?
Also when using the reports module. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Andreas Jonsson <andreas.jonsson@kreablo.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andreas.jonsson@kreablo.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Ola Andersson <ola.andersson@ltu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #14 from Ola Andersson <ola.andersson@ltu.se> --- There will be various ways of accessing personal information if you are skilled in Koha but the idea is to log obvious upfront abuse by staff. There will, when this patch is in place, be possible to communicate in the organisation that the system logs abuse of the Koha system. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 --- Comment #15 from Andreas Jonsson <andreas.jonsson@kreablo.se> --- Patron data can also be accessed via the REST-api, via the svc-api and via ILS-DI and via SIP2, and reports and plugins. A reasonable goal might be that all access to borrower information by a staff user with only edit_patron permissions should be logged. Maybe it is sufficient to add logging to the REST-api and svc-api in addition to this patch? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30279 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=25673 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org