[Bug 11400] New: Show "Login as a different user" instead of "Logout" if not enough premissions
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Bug ID: 11400 Summary: Show "Login as a different user" instead of "Logout" if not enough premissions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Authentication Assignee: gmcharlt@gmail.com Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11146 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 23576 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23576&action=edit Bug 11400: Show "Login as a different user" instead of "Logout" if not enough premissions Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23576|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23872 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23872&action=edit Bug 11400: Show "Login as a different user" instead of "Logout" if not enough premissions Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive this string change is worth. Simple and disputable string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 23912 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23912&action=edit screenshot of login page in Chromium I was about to pass it, as I like the idea, but it doesn't work very well with the limited width of the login box (see screenshot). In Firefox "different user" is on a new line for me. The screenshot is taken in Chromium. In German the text would even get a bit longer, if you translated it directly. Maybe center both buttons on their own line? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff Patch complexity|String patch |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 23952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23952&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23872|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #5 from David Cook <dcook@prosentient.com.au> --- The patch works, but I'm not sure that this improves the current behaviour. I suppose the "Logout" button was added so that people could end their session here? I suppose they could just use the "Previous page" button and then logout from there (or continue doing what they were doing). In any case, "Log in" should probably be "Login" to match the other button. Also, we might consider something more explanatory like: "Error: You do not have permission to access this page. Login as a different user or return to the previous page." Maybe even moving the "Previous page" button down to the bottom left corner to improve the aesthetic of the page? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to David Cook from comment #5)
I suppose the "Logout" button was added so that people could end their session here?
Yeah I've always wondered what the workflow there was: "Ooops, I reached a page I can't access. Instead of logging in as a different user right now I'm going to log out completely and give up."
In any case, "Log in" should probably be "Login" to match the other button.
Actually now that I look at it I think they should both be "Log in." "Login" should be used as a noun, "Log in" as a verb.
Also, we might consider something more explanatory like: "Error: You do not have permission to access this page.
Login as a different user or return to the previous page."
Maybe even moving the "Previous page" button down to the bottom left corner to improve the aesthetic of the page?
I like these suggestions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Depends on|11146 | Assignee|gmcharlt@gmail.com |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Scrolling through the last comments, I also agree that the Previous page button is not really placed very nice (not to say ugly :) Login is no verb, so it should be Log in. (Note that this occurs in more places.) And if you add the sentence "Log in as a different user", what about adding the other possibility of going back too? So: Log in as a different user or go back to the previous page? On the other hand, adding even more text and buttons will probably not improve the current form. So this is a hard one. Moving it to In Discussion -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Another bug stuck in 'In Discussion'... any further thoughts/developments people? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #9 from Marc Véron <veron@veron.ch> --- Created attachment 36001 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36001&action=edit Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #10 from Marc Véron <veron@veron.ch> --- I hope it is OK to switch to "Needs Signoff" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Marc Véron from comment #10)
I hope it is OK to switch to "Needs Signoff"
It is! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23952|0 |1 is obsolete| | --- Comment #12 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36015 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36015&action=edit Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36001|0 |1 is obsolete| | --- Comment #13 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 36016 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36016&action=edit Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, oleonard@myacpl.org --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- It does not look much nicer for me :) Ccing Owen to get his opinion. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36015|0 |1 is obsolete| | Attachment #36016|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36066 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36066&action=edit [PASSED QA] Bug 11400: Show "Log in as a different user" in the error message instead of the "Logout" button Bug 11146 introduced a way to go back, and have a logout link for the "Not enough permissions" message page. I belive the logout button is redundant. And also "Log in as a different user" tells the user more about its options on the scenario. Simple and disputable usability/string change. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36067 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36067&action=edit [PASSED QA] Bug 11400 - Follow-up for nicer design This patch tries to get the Bug out of "In discussion" by changing the design a little bit. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- See comment 14, I was waiting for feedbacks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11400 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org