[Bug 38412] New: Koha should warn when hold on bibliographic record requires hold policy override
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Bug ID: 38412 Summary: Koha should warn when hold on bibliographic record requires hold policy override Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs@lists.koha-community.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Depends on: 35573 When AllowHoldPolicyOverride is set to Allow, Koha will specifically mark items for which an item-level hold will require an override. However, nothing in the interface indicates when the bibliographic level hold will require an override. To recreate: - Have AllowHoldPolicyOverride set to Don't Allow - Have a bib record with just one item - confirm you can place a hold on either the biblio or the item - edit your item such that it become unholdable (mark it Not For Loan or something) - confirm that you cannot place a hold on either the biblio or the item - set AllowHoldPolicyOverride to Allow - confirm that Koha shows an alert on the item indicating that the hold will require an override - confirm that Koha does not indicate the bibliographic level hold will require an override Bug 33573 restored these alerts for items. I don't recall if we've ever had these alerts for biblios. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 [Bug 35573] Koha is not correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 --- Comment #1 from Thibaud Guillot (thibaud_g) <thibaud.guillot@biblibre.com> --- Created attachment 182450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182450&action=edit Bug 38412: Display warning on biblio level When no element is available, with AllowHoldPolicyOverride, a triangle appears on each element to be forced, but if you choose “next item available” without having any item available, you won't see anything. I think there's a small correction to be made in request.pl because there's no incrementation of $num_override when the item is to be forced... So I added it and logic did the rest. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 0 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) For testing go on biblio with books itemtype, and place a hold for a staff category patron 3) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 4) Apply this patch and restart_all 5) Refresh your browser page 6) Normally now there is a triangle into 'Place hold' submit button and an alert pops up after click on it. Sponsored by: BibLibre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Assignee|koha-bugs@lists.koha-commun |thibaud.guillot@biblibre.co |ity.org |m --- Comment #2 from David Nind <david@davidnind.com> --- Added assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182450|0 |1 is obsolete| | --- Comment #3 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 182767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182767&action=edit Bug 38412: Display warning on biblio level When no element is available, with AllowHoldPolicyOverride, a triangle appears on each element to be forced, but if you choose “next item available” without having any item available, you won't see anything. I think there's a small correction to be made in request.pl because there's no incrementation of $num_override when the item is to be forced... So I added it and logic did the rest. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 0 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) For testing go on biblio with books itemtype, and place a hold for a staff category patron 3) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 4) Apply this patch and restart_all 5) Refresh your browser page 6) Normally now there is a triangle into 'Place hold' submit button and an alert pops up after click on it. Sponsored by: BibLibre Signed-off-by: Andrew Fuerste Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- The new little triangle alert icon might be more visible if it were next to the button rather than within it, since it's a yellow icon and an orange button. But that's a minor quibble with a nice improvement. thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Bug 38412 depends on bug 35573, which changed state. Bug 35573 Summary: Koha is not correctly warning of overridden items when placing a hold if AllowHoldPolicyOverride https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35573 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cj.lynce@westlakelibrary.or | |g --- Comment #5 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 40323 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisette@bywatersolutions.co | |m --- Comment #6 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #4)
The new little triangle alert icon might be more visible if it were next to the button rather than within it, since it's a yellow icon and an orange button. But that's a minor quibble with a nice improvement. thanks!
I agree that it's not very visible and easy to miss. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Good step towards resolving this. I too agree that the current triangle on the button is hard to see, and not accessible. Next to the button would make it more visible (though even then I'm unsure if its accessible enough.) Additionally, it should display the same warning message at the top that displays when AllowHoldPolicyOverride is set to 'Dont Allow'. *Cannot place hold* No items are available to be placed on hold. This is similar in behavior to what happens when you try to place too many holds on a bib (more than circ rules allow) and AllowHoldPolicyOverride is set to Allow. Having the warning display with AllowHoldPolicyOverride set to Allow also explains the issue to staff, who hopefully read it before proceeding to override the hold. And it probably increases overall accessibility (with the warning icon.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182767|0 |1 is obsolete| | --- Comment #8 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Created attachment 184021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184021&action=edit Bug 38412: Display warning on biblio level When no item is available, with AllowHoldPolicyOverride, a triangle appears on each item to be forced, but if you choose “next item available” without having any item available, you won't see anything. Additionally, the top warning message about "No items are available" does not show when 'AllowHoldPolicyOverride' is set to allow and no items are available (e.g. withdrawn, lost, damanged, depending on settings) This patch corrects an error in request.pl where no incrementation of $num_override happens when an item is forced. This causes the warning triangle to appear on the 'Place hold' button on the bib level. The top warning message is restored as well. Finally, this patch changes the display of the fa-warning-triangle icon on the 'Place hold' buttons to increase contrast with the button color, making it easier to see and increasing accessibility. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 1 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) Search for a book biblio with multiple items, and set each item to a non-circulating status (withdrawn, lost, etc.) 3) Place a hold for a staff category patron for this bib record. 4) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 5) Apply this patch and restart_all. 6) Refresh your browser page. 7) Normally now there is a triangle into 'Place hold' submit button and an alert message appears on the top of the page. The triangle is also more visible. 8) Test other hold limits, such as max holds per record, to ensure the appropriate top alert message appears and the triangle alert appears on the 'Place hold' button. Co-authored-by: Thibaud Guillot <thibaud.guillot@biblibre.com> Sponsored-by: BibLibre Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 --- Comment #9 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Submitted a patch that builds up Thibaud's work, adds back the top warning message with explanation, and helps the contrast with the triangle warning on the buttons. I'm not entirely sure if this is the right way to submit a patch that adds on to someone else's in the same bug, so if not, I welcome feedback on how do this in the future. Thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184021|0 |1 is obsolete| | --- Comment #10 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184564&action=edit Bug 38412: Display warning on biblio level When no item is available, with AllowHoldPolicyOverride, a triangle appears on each item to be forced, but if you choose “next item available” without having any item available, you won't see anything. Additionally, the top warning message about "No items are available" does not show when 'AllowHoldPolicyOverride' is set to allow and no items are available (e.g. withdrawn, lost, damanged, depending on settings) This patch corrects an error in request.pl where no incrementation of $num_override happens when an item is forced. This causes the warning triangle to appear on the 'Place hold' button on the bib level. The top warning message is restored as well. Finally, this patch changes the display of the fa-warning-triangle icon on the 'Place hold' buttons to increase contrast with the button color, making it easier to see and increasing accessibility. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 1 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) Search for a book biblio with multiple items, and set each item to a non-circulating status (withdrawn, lost, etc.) 3) Place a hold for a staff category patron for this bib record. 4) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 5) Apply this patch and restart_all. 6) Refresh your browser page. 7) Normally now there is a triangle into 'Place hold' submit button and an alert message appears on the top of the page. The triangle is also more visible. 8) Test other hold limits, such as max holds per record, to ensure the appropriate top alert message appears and the triangle alert appears on the 'Place hold' button. Co-authored-by: Thibaud Guillot <thibaud.guillot@biblibre.com> Sponsored-by: BibLibre Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |emily.lamancusa@montgomeryc | |ountymd.gov --- Comment #11 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- The UI improvements look great, and this is a small but much-needed bugfix! To answer your question about building upon someone else's work, usually we submit a separate patch on top of the existing patch(es), rather than amending the original patch. I don't think we need to go back and redo the commits on this one (unless Thibaud or the RM feel otherwise) since it's not a big patch and the coauthor line gives credit, but that's the usual convention for future reference! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Katie Bliss <kebliss@dmpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kebliss@dmpl.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184564|0 |1 is obsolete| | --- Comment #12 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185005&action=edit Bug 38412: Display warning on biblio level When no item is available, with AllowHoldPolicyOverride, a triangle appears on each item to be forced, but if you choose “next item available” without having any item available, you won't see anything. Additionally, the top warning message about "No items are available" does not show when 'AllowHoldPolicyOverride' is set to allow and no items are available (e.g. withdrawn, lost, damanged, depending on settings) This patch corrects an error in request.pl where no incrementation of $num_override happens when an item is forced. This causes the warning triangle to appear on the 'Place hold' button on the bib level. The top warning message is restored as well. Finally, this patch changes the display of the fa-warning-triangle icon on the 'Place hold' buttons to increase contrast with the button color, making it easier to see and increasing accessibility. Test plan: 1) Set circulations rules for specific category and/or itemtype (for example 1 hold allowed for staff on books). Set AllowHoldPolicyOverride on "Allow". 2) Search for a book biblio with multiple items, and set each item to a non-circulating status (withdrawn, lost, etc.) 3) Place a hold for a staff category patron for this bib record. 4) Normally you will see triangles on each item on specific section but you can force it. When you just select the next item available none triangle and none alert showing. 5) Apply this patch and restart_all. 6) Refresh your browser page. 7) Normally now there is a triangle into 'Place hold' submit button and an alert message appears on the top of the page. The triangle is also more visible. 8) Test other hold limits, such as max holds per record, to ensure the appropriate top alert message appears and the triangle alert appears on the 'Place hold' button. Co-authored-by: Thibaud Guillot <thibaud.guillot@biblibre.com> Sponsored-by: BibLibre Sponsored-by: Westlake Porter Public Library <https://westlakelibrary.org> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 CJ Lynce <cj.lynce@westlakelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_25_05_candidate --- Comment #14 from CJ Lynce <cj.lynce@westlakelibrary.org> --- Can this be backported to 25.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #17 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38412 Adolfo Rodríguez Taboada <adolfo.rodriguez@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=42999 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org