[Bug 32171] New: Order prices not populated when adding to a basket form a staged file
From bug 29955 - in '3rd add order' we remembered to store the order after
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Bug ID: 32171 Summary: Order prices not populated when adding to a basket form a staged file Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org populating, when adding from a basket we didn't -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29955 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 [Bug 29955] Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |32166 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32166 [Bug 32166] When adding to a basket from a staged file we may use the wrong inputs -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143707&action=edit Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Order prices not populated |Order prices not populated |when adding to a basket |when adding to a basket |form a staged file |from a staged file -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Looks like you forgot to declare your oder: Could not compile /kohadevbox/koha/acqui/addorderiso2709.pl: Global symbol "$oder" requires explicit package name (did you forget to declare "my $oder"?) at /kohadevbox/koha/acqui/addorderiso2709.pl line 297. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/acqui/addorderiso2709.pl line 754. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143707|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 143901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143901&action=edit Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143901|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 143919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143919&action=edit Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- coopted the test plan from 32166: To test: -1: apply patch 0 - Set system preferences: MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l 1 - Stage attached sample file, Format:MARCXML, Record matching:Koha biblio 999$c 2 - Add to a basket from the staged file 3 - Select 1st record to basket and save 4 - Record is added with the fields above as expected AND THE PRICE FIELDS ARE POPULATED 5- repeat with the other records if you feel like it -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Bug 32171 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143919|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143954&action=edit Bug 32171: Store after populating order This updates the call to store after populating the order I put this on it's own bug just for sake of dependency, in case it is needed seperate from 32166 for backports To test: 1 - Apply and test with bug 32166 Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the help with the test plan, Andrew! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Bug 32171 depends on bug 29955, which changed state. Bug 29955 Summary: Move C4::Acquisition::populate_order_with_prices to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29955 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32171 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org