[Bug 14263] New: Export of CSV from item search form does only work in English
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Bug ID: 14263 Summary: Export of CSV from item search form does only work in English Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Exporting the results of an item search as CSV will only work for the English templates, but not for translated templates (German or French). To test: English templates: - Go to the item search form - Select CSV at the bottom of the page - Do a search - verify the CSV is ok and opens alright in LibreOffice - Switch to another fully translated language - Repeat steps - Verify the CSV is NOT ok - everything appears on one line -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14169 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m, | |julian.maurice@biblibre.com --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a bigger problem - also other CSV exports suffer from this: basket, late orders, serial claims. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11425 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39465&action=edit Bug 14263: Fix export of item search results when translated This csv does not use the correct way to display headers. They should be put in a separate file to get a correct display. Without this patch, the first line of the generated file contains the headers + data Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to the item search form using this language 3/ Launch a search and select CSV to display the results. The CSV headers should be correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #1)
This is a bigger problem - also other CSV exports suffer from this: basket, late orders, serial claims.
Should work for basket and serial claims. See bug 14169 for late orders. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14264 --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Jonathan Druart from comment #3)
(In reply to Katrin Fischer from comment #1)
This is a bigger problem - also other CSV exports suffer from this: basket, late orders, serial claims.
Should work for basket and serial claims. See bug 14169 for late orders.
See bug 14264! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- I can't make it working properly. Without the patch: 1 unique line. With it: 2 lines, one for field name, one for all records aggregated. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39465|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 39532 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39532&action=edit Bug 14263: Fix export of item search results when translated This csv does not use the correct way to display headers. They should be put in a separate file to get a correct display. Without this patch, the first line of the generated file contains the headers + data Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to the item search form using this language 3/ Launch a search and select CSV to display the results. The CSV headers should be correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Actually(In reply to Frédéric Demians from comment #5)
I can't make it working properly. Without the patch: 1 unique line. With it: 2 lines, one for field name, one for all records aggregated.
Sorry about that, I tested with a wrong record. This patch is dirty but works as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- (In reply to Jonathan Druart from comment #7)
Actually(In reply to Frédéric Demians from comment #5)
I can't make it working properly. Without the patch: 1 unique line. With it: 2 lines, one for field name, one for all records aggregated.
Sorry about that, I tested with a wrong record. This patch is dirty but works as expected.
Yes, your workaround reintroduces newlines required by CSV format. In the first place, the template toolkit translation machinery is the culprit, but can't be fixed that easily, unfortunately. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39532|0 |1 is obsolete| | --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 39533 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39533&action=edit Bug 14263: Fix export of item search results when translated This csv does not use the correct way to display headers. They should be put in a separate file to get a correct display. Without this patch, the first line of the generated file contains the headers + data Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to the item search form using this language 3/ Launch a search and select CSV to display the results. The CSV headers should be correct Signed-off-by: Frederic Demians <f.demians@tamil.fr> Seen the bug. Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch --- Comment #10 from Marc Véron <veron@veron.ch> --- Should this be set to Signed-off? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Frédéric Demians <frederic@tamil.fr> --- Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39533|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 39718 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39718&action=edit [PASSED QA] Bug 14263: Fix export of item search results when translated This csv does not use the correct way to display headers. They should be put in a separate file to get a correct display. Without this patch, the first line of the generated file contains the headers + data Test plan: 1/ choose a language and update + translate the templates for instance: cd misc/translate; ./translate update es-ES; ./translate install es-ES 2/ Go to the item search form using this language 3/ Launch a search and select CSV to display the results. The CSV headers should be correct Signed-off-by: Frederic Demians <f.demians@tamil.fr> Seen the bug. Works as described. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the quick fix! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #15 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.1 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14263 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #16 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.x, will be in 3.18.10. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org