[Bug 13450] New: Title and breadcrumb of Patron form can look weird in translations
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Bug ID: 13450 Summary: Title and breadcrumb of Patron form can look weird in translations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Example: English: Modify Kind patron Hansli Meier Modify Erwachsener patron Henry Acevedo German: Ändern Kind Benutzer Hansli Meier Ändern Erwachsener Benutzer Henry Acevedo It should be something like English: Modify patron Hansli Meier (Kind) Modify patron Henry Acevedo (Erwachsener) Ändern Benutzer Hansli Meier (Kind) Ändern Benutzer Henry Acevedo (Erwachsener) Note: (Kind) and (Erwachsener) are set as Category name in Patron category administration. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 34373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34373&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #2 from Marc Véron <veron@veron.ch> --- Still applies (Version 3.19.00.002) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34373|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 34739 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34739&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways Copy a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify Child patron Hansli Meier (Juvenile) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, bit confused - the description says it moves the category to the end, but that doesn't match what I see in the templates: When I edit an existing patron: Title: Modify Child patron <name> Breadcrumb: Home › Patrons › <name> › Modify Child patron Modify Adult patron Nicole Schneider Home › Patrons › Nicole Schneider › Modify Adult patron Double checked patch is applied and looking at the English templates. The categoryname at the end doesn't show up for me. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #5 from Marc Véron <veron@veron.ch> --- Hi Katrin, Did you test with the "Edit" links on the page, e.g. below "Date of birth" or "Library use"? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I checked the 'edit' in the toolbar and 'duplicate' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #7 from Marc Véron <veron@veron.ch> --- Created attachment 34763 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34763&action=edit How it works now: Different Edit buttons show different titels / bradcrumbs for same patron -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #8 from Marc Véron <veron@veron.ch> --- Created attachment 34764 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34764&action=edit How it looks after patch (use "Edit" below Date of birth) and proposition how it should be for all kinds of editing (from toolbar or from links on page) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That's not what I saw - I will have to go back and retest, but right now not sure where I went wrong :( -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #10 from Marc Véron <veron@veron.ch> --- No problem,I think the whole code is rather complicated. Please have a look at the proposition in my 2nd screenshot: The idea is to have both Category TYPE and category NAME, something like Modify patron Hansli Testmann (Child:Juvenile) ([TYPE]:[NAME]) If you think this would be OK I will provide a new patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #11 from Marc Véron <veron@veron.ch> --- Created attachment 34862 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34862&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34763|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34764|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- This patch creates invalid markup. I think it's just a missing </div>. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34862|0 |1 is obsolete| | --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 35258 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35258&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com --- Comment #14 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Patch tested with a sandbox, by Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35258|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #15 from sandboxes@biblibre.com <sandboxes@biblibre.com> --- Created attachment 35417 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35417&action=edit Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added) Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35417|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35616&action=edit [PASSED QA] Bug 13450 - Title and breadcrumb of Patron form can look weird in translations This patch moves the patron category name or category type at the end of title and breadcrumb for better translatability. Note: It does not change anything in functionallity, it only changes display of strings. To test: Apply patch Search a patron and edit it in all possible ways: 'Edit' button on top of details page, 'Edit' links in details page, 'Edit' links in search result table if multiple patrons are found) Duplicate a patron Create a new patron Make sure that title and breadcrumb appear in a meaningful way with pattern similar to the following: Modify patron Hansli Meier (Juvenile) (Missing </div> added) Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 35617 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35617&action=edit Bug 13450 [QA Followup] - Remove tab character from start of line Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Passed QA |Pushed to Master --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Status|Pushed to Master |Pushed to Stable --- Comment #19 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.18.x will be in 3.18.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13450 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_16_candidate CC| |mtj@kohaaloha.com --- Comment #20 from Mason James <mtj@kohaaloha.com> --- Possible selection for 3.16.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org