[Bug 20934] New: Biblio checkout history shows only current checkout
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Bug ID: 20934 Summary: Biblio checkout history shows only current checkout Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: josef.moravec@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To reproduce: 1) Checkout an item to a patron 2) Go to the biblio record for this item and show checkouts history - you see the current checkout 3) Check in the item back 4) Repeat 2), you will see there is not any checkout in checkouts history for this biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18403 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |rel_18_05_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart@bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20899 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 [Bug 20899] Patron name not showing on issuehistory.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 76043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76043&action=edit Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76043|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 76104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76104&action=edit Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> The patch works as expected. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Bug 20934 depends on bug 20899, which changed state. Bug 20899 Summary: Patron name not showing on issuehistory.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20899 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76104|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76141&action=edit Bug 20934: Fix display of old checkouts in the checkout history page Again a regression caused by commit fa54100dffe092e606f79b15692eedaf78f42e45 Bug 18403: Use patron-title.inc when hidepatronname is used [SPECIFIC for issuehistory] GetBiblioIssues does a union all with issues and old_issues, so we should old_issues as well. To make the join on the items table we need to define the item and patron methods. For consistency the relationships have been redefined (item instead of itemnumber, borrower instead of borrowernumber) in the DBIx::Class definition. This is not perfect but I think the best way to provide an easy to backport patch. It highlights that we need improvements in this area. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> The patch works as expected. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76142&action=edit Bug 20934: (QA follow-up) Fix pod in Koha::Old::Checkout Test plan: Run qa tools - it shouldn't complain about pod levels Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 76143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76143&action=edit Bug 20934: (QA follow-up) Fix showing number of records in checkout history Test plan: 0) Do not apply this patch 1) Go to biblio checkout history page (issuehistory.pl) 2) You'll see something like "Checked out ARRAY(0xf830378) times" 3) Apply this patch 4) Now you should see number of checkout history records Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #6 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Jonathan Druart from comment #1)
This is not perfect but I think the best way to provide an easy to backport patch.
It highlights that we need improvements in this area.
Maybe not perfect, but fixing the bug ;) Hope some thing will be fixed during merging issues and oldissues in future... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Adam Goforth <koha-support@international-library.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha-support@international- | |library.de --- Comment #8 from Adam Goforth <koha-support@international-library.de> --- The checkout history is used in a couple of workflows we have at my library, so it would be really nice if we didn't have to wait until upgrading to 18.11 to get this fix. Are there currently any plans to backport the fix to 18.05? If not, would it be helpful for me to create a patch for it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, this was just an oversight on my part... Not sure how I missed it 😗. I'll grab it shortly and reporeport back -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20934 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Depends on Bug 20899 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org