[Bug 27752] New: Correct eslint errors in batchMod.js
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Bug ID: 27752 Summary: Correct eslint errors in batchMod.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 23833, 27751 Following coding guideline JS8: "Follow guidelines set by ESLint," some errors should be corrected in batchMod.js. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23833 [Bug 23833] [Omnibus] JavaScript should conform to coding guidelines recommended by ESLint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27751 [Bug 27751] Phase out jquery.cookie.js: Batch item modifications -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 117158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117158&action=edit Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117158|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 117230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117230&action=edit Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- No changes to behaviour after applying the patch and walking through the test plan. With the Atom text editor and the linter-eslint package the number of error and warnings goes from 134 to 0! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #117230|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 117726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117726&action=edit Bug 27752: Correct eslint errors in batchMod.js This patch makes minor changes to batchMod.js in order to address errors raised by ESLint. These changes include whitespace changes, so diff accordingly. To test, apply the patch and go to Tools -> Batch item modification. - Submit a batch of barcodes for modification. - Uncheck some checkboxes to hide columns in the table showing your submitted items. - Return to the batch item modification page and submit your batch again. - The columns you selected should still be hidden. - Submit a batch of items for deletion. - The same columns should be hidden here too. To confirm that ESLint is happy with the changes you could open the file for editing using an editor with ESLint integration, or install ESLint on the command line: https://eslint.org/docs/user-guide/command-line-interface Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Correct eslint errors in |Correct ESLint errors in |batchMod.js |batchMod.js -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |21.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 21.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch makes minor release notes| |changes to batchMod.js used | |in Tools > Batch item | |modification. This | |addresses errors raised by | |ESLint, including white | |space changes, to make sure | |it meets coding guideline | |JS8: Follow guidelines set | |by ESLint. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00 |21.05.00,20.11.04 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 20.11.x for 20.11.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|21.05.00,20.11.04 |21.05.00,20.11.04,20.05.10 released in| | Status|Pushed to stable |Pushed to oldstable CC| |andrew@bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Pushed to 20.05.x for 20.05.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27752 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Not backported to oldoldstable (19.11.x). Feel free to ask if it's needed. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org