[Bug 32918] New: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Bug ID: 32918 Summary: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs@lists.koha-community.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Currently, the authorized values for the ERM categories are in installer/data/mysql/mandatory/auth_val_cat.sql which is the file for authorized value categories, and not translatable. These should be moved to installer/data/mysql/en/mandatory/auth_values.yml so that each language can translate them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146413&action=edit Bug 32918: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml This patch moves the authorized value insertions for ERM categories into the language-specific auth_values.yml file. To test: 1. Count the number of authorized values in the mandatory categories select count(*) from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); --> There should be 929 2. Delete the authorized values from these categories delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); 3. Apply patch 4. Load the mandatory authorized values ./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml --load 5. Redo step 1 --> There should be the same number (929) 6. Update translations cd misc/translator ./translate update xx-XX 7. Search the po/xx-XX-installer.po file for any of the loaded authorized values For example, grep AbstractAndIndex po/xx-XX-installer.po grep "Abstract and index" po/xx-XX-installer.po --> authorized values and descriptions should be translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146413|0 |1 is obsolete| | --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 146438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146438&action=edit Bug 32918: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml This patch moves the authorized value insertions for ERM categories into the language-specific auth_values.yml file. To test: 1. Count the number of authorized values in the mandatory categories select count(*) from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); --> There should be 929 2. Delete the authorized values from these categories delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); 3. Apply patch 4. Load the mandatory authorized values ./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml --load 5. Redo step 1 --> There should be the same number (929) 6. Update translations cd misc/translator ./translate update xx-XX 7. Search the po/xx-XX-installer.po file for any of the loaded authorized values For example, grep "Abstract and index" po/xx-XX-installer.po --> descriptions should be translatable -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- I had originally made the authorized values themselves translatable since they are English words, and for historical and legal reasons, that doesn't always fly here. Unfortunately, some of them trigger actions (like the 'closed' ERM_AGREEMENT_STATUS makes the 'Closure reason' drop down active in agreements), so we can't translate them... at least not all of them. Since I'm not sure which ones trigger actions, I removed all of them from the translations. Now, only the descriptions are translatable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|koha-bugs@lists.koha-commun |caroline.cyr-la-rose@inlibr |ity.org |o.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com Depends on| |32030 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Caroline Cyr La Rose from comment #3)
I had originally made the authorized values themselves translatable since they are English words, and for historical and legal reasons, that doesn't always fly here.
Unfortunately, some of them trigger actions (like the 'closed' ERM_AGREEMENT_STATUS makes the 'Closure reason' drop down active in agreements), so we can't translate them... at least not all of them. Since I'm not sure which ones trigger actions, I removed all of them from the translations. Now, only the descriptions are translatable.
Looking at the values I wish they'd follow a bit more closely recommendations for authorised values, not using _ (we do recommend against these for locations and collections for search reasons) and using capital letters. It would also make it easier to see that these are CODES and not words. But... as Caroline said, we cannot change this easily and it's an oversight that is hard to fix now (and certainly should not be fixed here. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146438|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146983&action=edit Bug 32918: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml This patch moves the authorized value insertions for ERM categories into the language-specific auth_values.yml file. To test: 1. Count the number of authorized values in the mandatory categories select count(*) from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); --> There should be 929 2. Delete the authorized values from these categories delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); 3. Apply patch 4. Load the mandatory authorized values ./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml --load 5. Redo step 1 --> There should be the same number (929) 6. Update translations cd misc/translator ./translate update xx-XX 7. Search the po/xx-XX-installer.po file for any of the loaded authorized values For example, grep "Abstract and index" po/xx-XX-installer.po --> descriptions should be translatable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 146984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146984&action=edit Bug 32918: (follow-up) Add new lines for formatting consistency This adds new lines between each authorised value for better readability and to match the formatting of the rest of the file. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146983|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147132&action=edit Bug 32918: ERM authorized values should be in installer/data/mysql/en/mandatory/auth_values.yml This patch moves the authorized value insertions for ERM categories into the language-specific auth_values.yml file. To test: 1. Count the number of authorized values in the mandatory categories select count(*) from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); --> There should be 929 2. Delete the authorized values from these categories delete from authorised_values where category in ('YES_NO', 'PAYMENT_TYPE', 'HSBND_FREQ', 'ERM_AGREEMENT_STATUS', 'ERM_AGREEMENT_CLOSURE_REASON', 'ERM_AGREEMENT_RENEWAL_PRIORITY', 'ERM_USER_ROLES', 'ERM_LICENSE_TYPE', 'ERM_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_STATUS', 'ERM_AGREEMENT_LICENSE_LOCATION', 'ERM_PACKAGE_TYPE', 'ERM_PACKAGE_CONTENT_TYPE', 'ERM_TITLE_PUBLICATION_TYPE', 'COUNTRY', 'LANG', 'qualif'); 3. Apply patch 4. Load the mandatory authorized values ./misc/load_yaml.pl --file installer/data/mysql/en/mandatory/auth_values.yml --load 5. Redo step 1 --> There should be the same number (929) 6. Update translations cd misc/translator ./translate update xx-XX 7. Search the po/xx-XX-installer.po file for any of the loaded authorized values For example, grep "Abstract and index" po/xx-XX-installer.po --> descriptions should be translatable Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146984|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 147133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147133&action=edit Bug 32918: (follow-up) Add new lines for formatting consistency This adds new lines between each authorised value for better readability and to match the formatting of the rest of the file. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Many hands makes light work, thankyou everyone! Pushed to 22.11.x for the next release -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32918 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED CC| |lucas@bywatersolutions.com Resolution|--- |FIXED --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Not needed for 22.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org