[Bug 35185] New: Remove is_html flag from sample notices for text notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Bug ID: 35185 Summary: Remove is_html flag from sample notices for text notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org We have a few notices that are not formatted using HTML tags, but are still marked as "is_html". This will cause issues with line breaks. Example: - module: members code: 2FA_OTP_TOKEN branchcode: "" name: "two-authentication step token" is_html: 1 title: "Two-authentication token" message_transport_type: email lang: default content: - "Dear [% borrower.firstname %] [% borrower.surname %] ([% borrower.cardnumber %])" - "" - "Your authentication token is [% otp_token %]." - "It is valid one minute." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158047&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY * WELCOME We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34704 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34704 [Bug 34704] Print templates are formatted incorrectly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The WELCOME notice needs to be fixed to be proper HTML as it includes a link to the catalog. Removing from patch set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158047|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158051&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158051|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 158053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158053&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158053|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 158206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158206&action=edit Bug 35185: Remove is_html flag from sample notices that are plain text Some notices had the is_html flag for new installations, but actually didn't include any HTML formatting. These should be plain text to have the line breaks behave as expected. This updates: * 2FA_OTP_TOKEN * OPAC_REG_VERIFY We cannot do a database update here, as libraries will have changed and updated these. So this is only for new installations. To test: * Apply patch * reset_all (create a new sample database) * Verify that the HTML checkbox is not set for these notices * Verify they appear as plain text notices, not including HTML tags Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|23.11.00 |23.11.00,23.05.06 released in| | --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|23.11.00,23.05.06 |23.11.00,23.05.06,22.11.12 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35185 --- Comment #9 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Nice work everyone! Pushed to 22.11.x for next release -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org