https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51292&action=edit Bug 16336 - UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16462 [Bug 16462] Change default sorting of circulation patron search results to patron name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51292|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51586&action=edit Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51586|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 51731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51731&action=edit [SIGNED-OFF] Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51731|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 51748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51748&action=edit Bug 16336 [Revised] UX of holds patron search with long lists of results Bug 15793 made a change to an interface which is also found in the place hold template. This patch creates a new include file to be used by both circulation.tt and request.tt so that these pages do not diverge. In the process, this patch removes some markup and JavaScript which was made obsolete by Bug 15793 and should have been removed. This patch also revises the sorting of the results table so that the patron name is sortable (Bug 16334) and the default sort is on card number (matching 3.20.x and 3.22.x). To test: In Circulation: - Perform a search by name for a patron which will return multiple search results. - The table of results which displays should look correct and work correctly, including DataTables sorting. - Clicking any table row should forward you to the checkout page for that patron. In the catalog: - Locate and place a hold on a title. - When prompted to select a patron to place the hold for, perform a search by name which will return multiple results. - Confirm that the table of patron results looks correct and works correctly. - Clicking any table row should forward you to the place hold page for that patron and the title you selected. Revision: Although the table row was clickable, you couldn't middle-click it to open the link in a new tab. The patron name is now a real link you can middle-click or right-click. The row is still clickable as well. Signed-off-by: Aleisha <aleishaamohia@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)

I am wondering why branchcode and categorycode are displayed, instead of their description, on these 2 tables. Any valid reasons?

It is probably simply a remnant of the old version which displayed the list in a <select> and required a more compact display. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the November 2016 Release. Thanks -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16336 --- Comment #10 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #7)

A patch is going to be submitted on bug 16336.

Read bug 16596. -- You are receiving this mail because: You are watching all bug changes.