[Bug 10218] New: label 'online access' with id for css
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bug ID: 10218 Summary: label 'online access' with id for css Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: nengard@gmail.com Created attachment 18028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18028&action=edit online access id See attached. It would be nice to be able to style the 'online access' text but the label doesn't have a unique ID. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.10 |master Summary|label 'online access' with |In OPAC XSLT search |id for css |results, add class to | |'online access' -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18119 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18119&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18119|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 18295 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18295&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18295|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 18402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18402&action=edit Bug 10218 - In OPAC XSLT search results, add class to 'online access' In some cases in OPAC search results and the detail page there is a class specific to each line of data being output (publisher, date, subjects, etc). In other cases there is no additional class. This patch makes modifications to a few different OPAC files in an attempt to make them consistent with each other. To test, apply the patch and view: - an OPAC detail page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay off - the OPAC search results page with OPACXSLTDetailsDisplay on Labels should have classes relevant to their data. To test the specific case requested by this bug, view details/results for a record which includes online resources (856u in MARC21). Signed-off-by: Galen Charlton <gmc@esilibrary.com> html changes only, passes all tests Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- I did not look, but I suppose a followup can be made for UNIMARC (in an other patch?) M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED CC| |gmcharlt@gmail.com Assignee|oleonard@myacpl.org |mathieu.saby@univ-rennes2.f | |r --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! Setting status to assigned to Mathieu for a UNIMARC followup. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18402|0 |1 is obsolete| | --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 18402 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18402 Bug 10218 - In OPAC XSLT search results, add class to 'online access' Marking patch obsolete now that it has been pushed to master but with a UNIMARC follow-up to be expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Galen, I never really understood that : must or must not a followup for a patch already pushed in master be attached to a new bug ?
From a discussion under an other bug, I believe it is a good practice?
M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #8 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #7)
Galen, I never really understood that : must or must not a followup for a patch already pushed in master be attached to a new bug ? From a discussion under an other bug, I believe it is a good practice?
Well, the original bug description didn't specify that it was a MARC21-only bug. The perfect patch for this bug would have handled all of the MARC flavors that are currently supported, but as that didn't happen, I chose to leave the bug open. More broadly: unless a bug is truly specific to a particular MARC format, IMO we should aim for *complete* patches. However, this is a preference, not a requirement. If you prefer to open a new bug, you are free to do so. If you do that, please link it to this one via a dependency or a comment citing the new bug number. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- In the past, some other bugs about XSLT or installation were MARC21 specific, without anouncing it. As you said, it is pretty annoying... I will add a followup on this bug, and change the status to Need Signoff. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #10 from Galen Charlton <gmcharlt@gmail.com> --- I pinged Magnus on IRC about this bug, as presumably the NORMARC stylesheets should be updated as well. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.1. Leaving as ASSIGNED, waiting for the followups. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #12 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Sorry, my VM is broken, so the followups won't be there until some days... Mathieu. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #13 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.7 Leaving as ASSIGNED. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #14 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 18948 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18948&action=edit [PATCH] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Summary|In OPAC XSLT search |In OPAC XSLT search |results, add class to |results, add class to |'online access' |'online access' - UNIMARC -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #15 from Liz Rea <liz@catalyst.net.nz> --- Title changed as MARC support has been pushed, and UNIMARC patches are waiting. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18948|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20678&action=edit Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20678|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 20679 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20679&action=edit [SIGNED-OFF] Bug 10218 : Followup for UNIMARC Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|In OPAC XSLT search |Add individual CSS classes |results, add class to |for bibliographic |'online access' - UNIMARC |information on OPAC results | |and detail pages (UNIMARC) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20679|0 |1 is obsolete| | --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 20861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20861&action=edit [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Follow-up for UNIMARC XSLT Display This patch adds class to span markup in list and detail display. XSLT are not build in the same way in MARC21 and UNIMARC, so I had to add a parameter "spanclass" to 3 templates called in UNIMARC : tag_title, tag_7xx, tag_comma To test, apply the patch on a Koha instance with UNIMARC records, and - activate sysprefs OPACXSLTDetailsDisplay and OPACXSLTDetailsDisplay - make a search on the OPAC. In the results, check the spans with "results_summary" class have also more a precise class. Ex : span class="results_summary publication" - view some records in detailed view. If possible, a record with a series, a record with some subjects, a record with different authors, a record with a link in 856. Check the spans with "results_summary" have also a more precise class. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Comment: Works exactly as described on results and detail. No koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> XSLT only change. Tested in a UNIMARC install, HTML source code looks ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20861|0 |1 is obsolete| | --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 20861 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20861 [PASSED QA] Bug 10218: Add individual CSS classes for bibliographic information in OPAC (UNIMARC) Pushed to master. Thanks, Mathieu! Setting back to assigned; only NORMARC remains. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Magnus Enger <magnus@enger.priv.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@enger.priv.no See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7490 --- Comment #20 from Magnus Enger <magnus@enger.priv.no> --- There is already a bug called "Bug 7490 - Add CSS classes/ids to OPAC and staff NORMARC XSLT views" - I'll use that when I get around to dealing with this issue. Thanks for remembering poor old NORMARC! :-) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #21 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.6. Thanks Mathieu! Marked 'Pushed to stable' as there's a NORMARC-specific bug for the remaining NORMARC fix. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #22 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.12 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10218 --- Comment #23 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Same changes must be made to new bootstrap opac. Mathieu -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org