[Bug 12133] New: Guarantor requirements when registering a patron
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Bug ID: 12133 Summary: Guarantor requirements when registering a patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: pasi.kallinen@pttk.fi QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Created attachment 27517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27517&action=edit Add two requirements when registering a new patron Attached patch adds two new requirements when registering a new patron: - A child patron must have a guarantor. - A guarantor cannot be a guarantee. Both of these stem from legal requirements in Finland - these might not be applicable for everywhere, so perhaps a syspref to control one, or both, might be in order? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to paxed from comment #0)
so perhaps a syspref to control one, or both, might be in order?
My library would definitely want a system preference to control the first option (child must have a guarantor). The second option seems like simple logic to me, but I've learned not to trust my sense of logic in these matters. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 paxed <pasi.kallinen@pttk.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27517|0 |1 is obsolete| | Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |pasi.kallinen@pttk.fi |ity.org | --- Comment #2 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 27584 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27584&action=edit Guarantor requirements when registering a patron Add two requirements when registering a new patron Attached patch adds two new requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor, which defaults to off. - A guarantor cannot be a guarantee. Both of these stem from legal requirements in Finland. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com Component|Staff Client |Patrons Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Please provide a test plan. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #4 from paxed <pasi.kallinen@pttk.fi> --- To test: 1) Add a new child patron. It will be successful without a guarantor. 2) Add a new child patron, with guarantor set to some other patron who already has a guarantor. Adding the child patron is successful. 3) Add a new non-child patron, with guarantor set to some other patron who already has a guarantor. Adding the patron is successful. 4) Install patch 5) Add a new child patron. It will be successful without a guarantor. 6) Add a new child patron, with guarantor set to some other patron who already has a guarantor. Adding the child patron should fail with error message. 7) Add a new non-child patron, with guarantor set to some other patron who already has a guarantor. Adding the patron should fail with error message. 8) Set syspref ChildNeedsGuarantor to ON 9) Try to add a new child patron without a guarantor. It should fail with error message. 10) Add a new non-child patron. It will be successful without a guarantor. 11) Set syspref ChildNeedsGuarantor to OFF 12) Repeat the steps 5-10, but instead of adding a patron, edit already existing patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 --- Comment #5 from ppp@inlibro.com --- Created attachment 33459 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33459&action=edit [SIGNED-OFF] Bug 12133: Guarantor requirements when registering a patron Add two requirements when registering a new patron: - A child patron must have a guarantor. This is controlled by a new syspref ChildNeedsGuarantor. - A guarantor cannot be a guarantee. Signed-off-by: ppp <ppp@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 ppp@inlibro.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |ppp@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #27584|0 |1 is obsolete| | CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- On master, you can set a firstname+surname as guarantor. You are not forced to choose an existing patron. With you patch, pref enabled, it's not possible to do that. Worse, if you try to edit a patron without guarantorid, you are not allowed to save any changes. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12133 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ppp@inlibro.com |philippe.blouin@inlibro.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org