[Bug 17916] New: "Delete MARC modification template" fails to actually delete it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Bug ID: 17916 Summary: "Delete MARC modification template" fails to actually delete it Change sponsored?: --- Product: Koha Version: 16.11 Hardware: PC OS: Windows Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: jsterben@umich.edu QA Contact: testopia@bugs.koha-community.org As of 16.11.00 on Ubuntu 14.04, attempting to delete a MARC modification template (Tools > MARC Modification templates) does not work. A change to the MARC modification template interface was noted in the upgrade to 16.11.x from 16.05.x, where the functionality did work correctly (as it had in any release used since 3.18) VERIFY: *Upon selecting "Delete" for the appropriate template, system will prompt "Are you sure you wish to delete this template action" (select "OK") and then "Are you sure you wish to delete this template" (select "OK" again). There is no response by the system after this final "OK". The screen is not refreshed as expected and the template remains in place, fully intact with no changes as though no action had been taken. NOTES: *The "Are you sure you wish to delete this template action" prompt seems out of place given the goal of deleting the entire template, not just a single element therein. *Problem exists for both modification templates carried forward from other koha releases as well as for templates created "new" in 16.11. *"Edit actions" and "Duplicate" functions appear to work without issue. *User confirmed to have superlibrarian privileges. *PC running Chrome 55.0.x on Win7 Enterprise, though also confirmed in Firefox 50.1.0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Hardware|PC |All CC| |katrin.fischer@bsz-bw.de Version|16.11 |master OS|Windows |All --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I can reproduce this bug on current master. Deleting single actions work, deleting a whole template asks twice, doesn't delete. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jens.weber@phsh.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 62676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62676&action=edit Bug 17916 - "Delete MARC modification template" fails to actually delete it The MARC modification templates' 'Delete' button fails because the event handler has a "preventDefault" but the outcome of the confirmation function must return true or false. This patch removes the "preventDefault" from the .delete_template click handler as well as a redundant onclick attribute from the delete link itself. To test, apply the patch and go to Tools -> MARC modification templates. Clicking the delete button for any existing template should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62676|0 |1 is obsolete| | --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 62680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62680&action=edit Bug 17916 - "Delete MARC modification template" fails to actually delete it The MARC modification templates' 'Delete' button fails because the event handler has a "preventDefault" but the outcome of the confirmation function must return true or false. This patch removes the "preventDefault" from the .delete_template click handler as well as a redundant onclick attribute from the delete link itself. To test, apply the patch and go to Tools -> MARC modification templates. Clicking the delete button for any existing template should work correctly. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62680|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62681&action=edit Bug 17916 - "Delete MARC modification template" fails to actually delete it The MARC modification templates' 'Delete' button fails because the event handler has a "preventDefault" but the outcome of the confirmation function must return true or false. This patch removes the "preventDefault" from the .delete_template click handler as well as a redundant onclick attribute from the delete link itself. To test, apply the patch and go to Tools -> MARC modification templates. Clicking the delete button for any existing template should work correctly. Followed test plan, worked as intended Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |16148 CC| |jonathan.druart@bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16148 [Bug 16148] Revised layout and behavior of marc modification template management -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. Small conflict in the template. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Jens Weber <jens.weber@phsh.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mishravk79@gmail.com --- Comment #7 from Jens Weber <jens.weber@phsh.ch> --- *** Bug 18619 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17916 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #8 from Mason James <mtj@kohaaloha.com> ---
As of 16.11.00 on Ubuntu 14.04, attempting to delete a MARC modification template (Tools > MARC Modification templates) does not work. A change to the MARC modification template interface was noted in the upgrade to 16.11.x from 16.05.x, where the functionality did work correctly (as it had in any release used since 3.18)
skipping for 16.05.x series -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org