http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #2 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 22021 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22021&action=edit [PATCH] Bug 9807 : Make possible to view a basketgroup without reopening it This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #4 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to mathieu saby from comment #3)

Next step for improving basketgroup management will be Bug 10919

M. Saby

And make links from other pages (orders, baskets...) to a specific basket group when it is needed (it was not possible before this patch, because it reopened automatically the basketgroup...) M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22021|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #7 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Thank you Pierre and Cedric! Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #9 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #8)

I am a little bit disconcerted. The aqbasketgroup.tt is really dirty and it is not easy to do something in it.

=> so true. it's horrible. And very hard to understand without reindenting...

But this patch is not really clear: 1/ I don't know if to add a lot of simple comment is useful (in the pl file).

It was usefull for me, to understand how the file was structured. But I can suppress comments if they are unneeded.

4/ There is a mix between new code and indentation fixes (use the -w option for git show).

For me reindentation were logical, because I add a new condition in the template (l. 147: [% IF (closedbg) %] ), so I felt free to reindent For the other points, I cannot answer quickly, and must watch it closely. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #11 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- The closedbg variable passed to template is used to decide if the bg must be only displayed, or make editable. By the way, I've remarked a typo : "closedgb" for "closedbg". I'm writing a followup. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #13 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 22782 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22782&action=edit [PATCH 2] Bug 9807 : Followup fixing variable name Fixing closedbg name in template -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22781|0 |1 is obsolete| | --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 22792 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22792&action=edit [PATCH ] Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting Should be more easy to understand. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22792|0 |1 is obsolete| | --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 22812 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22812&action=edit Bug 9807 : Make possible to view a basketgroup without reopening it Patch rewritten to eliminate reindenting This patch make possible to view an individual closed basketgroup without reopening it. - It adds a new "View" button on closed basketgroup list - It creates a view for closed basketgroups, with 3 buttons (reopen, print, export) - It adds a "delete" button on standard "edit" view (for open basketgroup) To test : 1/ regression test : - create some empty basketgroups - create some basketgroups by closing baskets - in the list of basketgroups closed and opened, check you can use the buttons that existed before the patch (close and print, delete, export, print, reopen) - click on "Edit" to edit a opened basketgroup : check everything is like before : -- change the billing and delivery places, -- add a note, -- put some new baskets in the bg, -- remove baskets from it -- save it without checking "close" box => it must be save but kept open -- edit it again, and make other some changes (define a free delivery place for example) -- save it with checking "close" => it must be saved but closed 2/ new feature test - click on "view" button on top right column of some closed basketgroup - check all the displayed informations are correct (places, free place, note, list of baskets) - check you can not change anything - click on "print" button => check a pdf is created - click on "export" button => check a csv is created - click on "reopen" button => you must stay on the same basketgroup, but it is now open and you can make some changes - go back to the basketgroup list of the vendor. Check the reopened bg is in "open" tab - click on "edit" - click on new "delete" button => the bg must be deleted, and you are redirected to the bg list of the vendor. Signed-off-by: cedric.vita@dracenie.com <cedric.vita@dracenie.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Passes koha-qa.pl, t and xt. Works as advertised. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |kyle@bywatersolutions.com --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- I would like to note that the pdf print view is a "interesting" but certainly no reason to not pass qa. I think a long term future goal should be to enable Template Toolkit for slips and notices, and then perhaps switch print views such as this to being html views configurable via slips and notices. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22793|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Needs Signoff --- Comment #22 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Regression test : - check the list of opened and closed basketgroups for a vendor is displayed properly - check an individual basketgroup (closed and opened) is displayed properly - check you can edit a basketgroup and save changes - check you can print and export a basketgroup - check you can close and reopen a basketgroup The last attachment Needs signoff. The 2 firsts have passed QA M. Saby -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as expected.. the final patch really is just a indenting clean up. Patch still works, patches all still pass qa script and code looks much nicer. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #26 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Martin Renvoize from comment #25)

Passing QA for that final followup. It's a template tidy up which doesn't affect operation.

It'll affect blame as it change whitespace (which can be ignored by -w) but also breaks lines.

I'm not sure that discussion ever came to an end, but I don't see why the initial two patches can't get pushed?

Hello Discussion with whom? In fact, if someone really does not want this followup, of course I can suppress the patch. But I think the reindenting on this file was really needed and will make further changes easier ;-) Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 --- Comment #28 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Martin Renvoize from comment #27)

Hi Mathieu,

There were a few IRC converstaions and a thread on the mailing list about tidying the whole koha codebase at some point.. I think the final decision was to just do it as we go along instead of a massive change.. which is exactly what you've done here so is good..

I'de leave the patch in, now it's marked passed QA it'll pass by Galen attention and I'm sure he'll make a sensible decision either way.

Martin

OK I remember having read - not to mix reindenting and new code in the same commit - not to do a patch only for reindenting So, as this bug changes some behavior in a template file, I think it is legitimate to add a followup for reindenting the file. Mathieu -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9807 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |9654 -- You are receiving this mail because: You are watching all bug changes.