[Bug 27490] New: Rename system preference language to StaffInterfaceLanguage
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Bug ID: 27490 Summary: Rename system preference language to StaffInterfaceLanguage Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org find all of the places in the code that refer to the 'language' system preference and rename them to 'StaffInterfaceLanguage' write an atomic update to rename the language system preference to StaffInterfaceLanguage in the preferences table in the database rename the language syspref in sysprefs.sql refer to bug 10328 for an example -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rename system preference |Rename system preference |language to |language to |StaffInterfaceLanguage |StaffInterfaceLanguages --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- instead of StaffInterfaceLanguage, make that StaffInterfaceLanguages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mazen.i.khallaf@gmail.com |ity.org | Status|NEW |ASSIGNED CC| |mazen.i.khallaf@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Blocks| |10327 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10327 [Bug 10327] Rename poorly named system preferences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Mazen Khallaf <mazen.i.khallaf@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mazen.i.khallaf@gmail.com | Assignee|mazen.i.khallaf@gmail.com |koha-bugs@lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW CC| |gmcharlt@gmail.com Component|Architecture, internals, |System Administration |and plumbing | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Isobel Graham <isobel.graham09@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isobel.graham09@gmail.com Assignee|koha-bugs@lists.koha-commun |isobel.graham09@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #2 from Koha Training Catalyst <koha-training@catalyst.net.nz> --- Created attachment 169631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169631&action=edit Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |wainuiwitikapark@catalyst.n | |et.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- Hi. Everything works as per the test plan. However, I tried with another language (de-DE) installed: - Before the patch, I can switch languages in the staff interface. - After the path, I can't switch languages. When trying to switch the language, the language didn't change and remained in English. (The OPAC worked correctly.) In addition, to get credit on the dashboard (https://dashboard.koha-community.org/), and to be listed as a Koha developer on the Koha timeline page, I think the assignee for the bug needs updating. I've changed the status to Failed QA 8-( David Testing notes (using koha-testing-docker (KTD)): 1. Apply the patch. 2. Update the database: updatedatabase 3. As per the test plan 4. To install another language: . koha-translate --install de-DE --dev kohadev . restart_all (not sure if this is really required) . enable the language: StaffInterfaceLanguages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #4 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 169805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169805&action=edit Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Doris Tam <doristam@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|isobel.graham09@gmail.com |doristam@catalyst.net.nz CC| |doristam@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169631|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 169914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169914&action=edit Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169805|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 169915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169915&action=edit Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement renames release notes| |the 'language' system | |preference to | |'StaffInterfaceLanguages', | |to make the name clearer | |and more meaningful. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this is a good change, but we are missing a few occurences: installer/data/mysql/localization/de-DE/custom.sql:UPDATE systempreferences SET value = 'de-DE,en' WHERE variable = 'language'; installer/data/mysql/localization/fr-CA/custom.sql:UPDATE systempreferences SET value = 'fr-CA,en' WHERE variable = 'language'; installer/data/mysql/localization/fr-FR/custom.sql:UPDATE systempreferences SET value = 'fr-FR' WHERE variable = 'language'; installer/data/mysql/localization/it-IT/custom.sql:UPDATE systempreferences SET value = 'en,it-IT' WHERE variable = 'language'; installer/data/mysql/localization/nb-NO/custom.sql:UPDATE systempreferences SET value = 'nb-NO' WHERE variable = 'language'; installer/data/mysql/localization/ru-RU/custom.sql:UPDATE systempreferences SET value = 'ru-RU,uk-UA,en,fr-FR,de-DE' WHERE variable = 'language'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe this was a Catathon patch - please let us know if you need help with the follow-up or someone to jump in here! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #9 from Doris Tam <doristam@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #8)
I believe this was a Catathon patch - please let us know if you need help with the follow-up or someone to jump in here!
Yes, please feel free to follow up and jump in on fixing up this patch. It was a Catathon patch and I no longer have a Koha environment to continue :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169914|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 170965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170965&action=edit Bug 27490: Update systempreference 'language' to 'StaffInterfaceLanguages' Test plan 1. Go to the staff client 2. Go to administration 3. Search systempreferences for 'StaffInterfaceLanguages' 4. Ensure there is a systempreference variable matching 'StaffInterfaceLanguages' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169915|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 170966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170966&action=edit Bug 27490: More instances of changing language syspref to StaffInterfaceLanguages Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 170967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170967&action=edit Bug 27490: (follow-up) Fix custom installer files -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Nicolas Hunstein <nicolas.hunstein@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.hunstein@bsz-bw.de Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #13 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up looks great, thanks Katrin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Martin Renvoize from comment #13)
Follow-up looks great, thanks Katrin
Wasn't me :) Thanks Nicolas! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #16 from Jonathan Druart <jonathan.druart@gmail.com> --- misc4dev needed adjustments, see https://gitlab.com/koha-community/koha-misc4dev/-/issues/80 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to main |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- --- Comment #17 from David Nind <david@davidnind.com> --- Changed status to "Needs documenting", as the manual does need updating to reflect this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com Documentation| |Aude Charillon contact| | Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/1010 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #18 from Aude Charillon <aude.charillon@ptfs-europe.com> --- Koha Manual updated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27490 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |39745 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39745 [Bug 39745] Wrong system preference 'language' in test suite -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org