[Bug 12264] New: Tiny typo in t/db_dependent/Items.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Bug ID: 12264 Summary: Tiny typo in t/db_dependent/Items.t Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Test Suite Assignee: magnus@enger.priv.no Reporter: magnus@enger.priv.no QA Contact: gmcharlt@gmail.com t/db_dependent/Items.t has these lines: 172 $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 0 }); 173 ok( $item->effective_itemtype() eq 'BIB_LEVEL', '$item->itemtype() returns biblioitem.itemtype when item-level_itypes is disabled' ); 174 175 $schema->resultset('Systempreference')->update_or_create({ variable => 'item-level_itypes', value => 1 }); 176 ok( $item->effective_itemtype() eq 'ITEM_LEVEL', '$item->itemtype() returns items.itype when item-level_itypes is disabled' ); I believe the last line should be "...when item-level_itypes is enabled". No practical impact, but it might be confusing to someone at some time. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33397 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33397&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |katrin.fischer@bsz-bw.de Assignee|magnus@enger.priv.no |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33397|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 33405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33405&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33405|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33408 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33408&action=edit Bug 12264: Correct tiny typo in t/db_dependent/Items.t One of the tests claims 'item-level_itypes is disabled' when it should be 'item-level_itypes is enabled'. Patch fixes this. To test: - run t/db_dependent/Items.t - tests should all pass - verify the last test reads 'enabled' - look at the code and see it's true Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 33409 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33409&action=edit Bug 12264: [QA Follow-up] Fixing biblionumber/biblioitemnumber mixup While testing the string change on 12264, I had this result: DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. DBD::mysql::st execute failed: Column 'biblioitemnumber' cannot be null at /usr/share/koha/testclone/C4/Items.pm line 2191. # Child (GetItemsInfo tests) exited without calling finalize() not ok 4 - GetItemsInfo tests This was caused by this line in the unit test: my $biblionumber = get_biblio(); This routine returns: return ($bibnum, $bibitemnum); So instead of the bibnum the bibitemnum is saved in biblionumber. In my test database bibnum and bibitemnum somehow got out of sync, revealing this bug :) The fix is just adding parentheses: my ( $biblionumber ) = get_biblio(); Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl QA Contact|gmcharlt@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12264 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks Katrin and Marcel! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org