https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |oleonard@myacpl.org Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48148&action=edit Bug 15828 - Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. https://bugs.koha-community.org/show_bug.cgi?id=15282 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48148|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 48149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48149&action=edit [SIGNED-OFF]Bug 15828: Upload patron images is hard to read The styling of the patron image upload form causes the text to be smaller than it should be for the main body of a page. This patch revises the form style and cleans up the markup a bit. This patch also adds client-side validation of the form so that a file upload is required, and a card number is required if an image file is selected. To test, apply the patch and go to Tools -> Upload patron images. 1. Confirm that the text in the form is the correct size. 2. With "Zip file" selected, confirm that submitting the form is blocked and the file upload marked as required. 3. With "Image file" selected, confirm that submitting the form with an empty card number field is blocked and the card number field is marked as required. 4. Confirm that uploading zip files and single images still works correctly. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 48274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48274&action=edit Bug 15828: Remove the required class on label Otherwise the label is red and a bit agressive :) Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15828 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks. -- You are receiving this mail because: You are watching all bug changes.