[Bug 16600] New: Remove some obsolete references to Greybox in some templates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Bug ID: 16600 Summary: Remove some obsolete references to Greybox in some templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org In identifying what templates still use Greybox for Bug 8290 I found two templates which contain obsolete references to Greybox code: authorities/merge.tt cataloguing/z3950_auth_search.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 51839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51839&action=edit Bug 16600 - Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8290 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51839|0 |1 is obsolete| | --- Comment #2 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 52867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52867&action=edit [SIGNED-OFF]Bug 16600: Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Obsolete comment on 'Card' removed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |hector.hecaxmmx@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16811 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16811 [Bug 16811] Remove multiple onclick event from z3950_auth_search.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16812 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16812 [Bug 16812] Remove multiple onclick event from z3950_auth_search.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #52867|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 52875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52875&action=edit Bug 16600 - Remove some obsolete references to Greybox in some templates This patch removes unused Greybox markup from two templates. To test, apply the patch and go to Authorities. - Perform an authority search which will return multiple results. - Select two records to merge. - On the "merging records" page, an earlier version used Greybox to show a preview of the selected authority records. Confirm that authority number link for the two records triggers a pop-up window instead. - From the authorities home page, choose 'New from Z39.50' - Perform a search which will return multiple results. - Confirm that there is only a 'MARC' preview link. A forever-commented-out 'Card' link has been removed. Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works as advertised. Obsolete comment on 'Card' removed Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16600 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |frederic@tamil.fr --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Pushed in 16.05. Will be in 16.05.02. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org