[Bug 17651] New: t/db_dependent/api/v1/patrons.t is failing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Bug ID: 17651 Summary: t/db_dependent/api/v1/patrons.t is failing Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org [Thu Nov 17 14:16:50 2016] [debug] GET "/api/v1/patrons" [Thu Nov 17 14:16:50 2016] [debug] Routing to a callback [Thu Nov 17 14:16:50 2016] [debug] Nothing has been rendered, expecting delayed response [Thu Nov 17 14:16:50 2016] [debug] Swagger2 routing to controller "Koha::REST::V1::Patron" and action "list" [Thu Nov 17 14:16:50 2016] [debug] 500 Internal Server Error (0.121564s, 8.226/s) ok 15 - GET /api/v1/patrons not ok 16 - 200 # Failed test '200 OK' # at t/db_dependent/api/v1/patrons.t line 122. # got: '500' # expected: '200' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- If borrowers.updated_on is null, the tests will fail -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17621 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |jonathan.druart@bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57604&action=edit Bug 17651: borrowers.updated_on can be null - swagger def The swagger file does not consider borrowers.updated_on as a nullable value, it should Test plan: 0/ Do not apply this patch 1/ update borrowers set updated_on=null; 2/ prove t/db_dependent/api/v1/patrons.t => Fail 3/ Apply this patch 4/ prove t/db_dependent/api/v1/patrons.t => green -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57604|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 57607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57607&action=edit Bug 17651: borrowers.updated_on can be null - swagger def The swagger file does not consider borrowers.updated_on as a nullable value, it should Test plan: 0/ Do not apply this patch 1/ update borrowers set updated_on=null; 2/ prove t/db_dependent/api/v1/patrons.t => Fail 3/ Apply this patch 4/ prove t/db_dependent/api/v1/patrons.t => green Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17654 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Trivial tests fix, passing QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.11, thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17651 Pete Edwards <koha@jsense.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21219 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org