[Bug 11155] New: PostgreSQL schema contains syntax errors
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Bug ID: 11155 Summary: PostgreSQL schema contains syntax errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Database Assignee: gmcharlt@gmail.com Reporter: dan@coffeecode.net QA Contact: testopia@bugs.koha-community.org Created attachment 22507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22507&action=edit Fixes syntax errors in PostgreSQL db schema installer/data/Pg/kohastructure.sql contains two syntax errors: * "mediumtext" is not a valid data type for PostgreSQL * "branch_transfer_limits_pkey" defines the primary key twice, which causes an error for PostgreSQL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer@bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Dan, I am marking this WONTFIX, because we currently do not maintain the PostgresSQL db schema and it's outdated. To my knowledge Koha can currently not be used with PostgresSQL, but it might be possible sometime in the future, as we have started using DBIX::Class. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 --- Comment #2 from Dan Scott <dan@coffeecode.net> --- Okay. Would you entertain a patch that removes the PostgreSQL cruft, then, so that people like me don't waste our time in the future? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|WONTFIX |--- --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Dan Scott from comment #2)
Okay. Would you entertain a patch that removes the PostgreSQL cruft, then, so that people like me don't waste our time in the future?
Yes, we will. Note that the general idea is that in the next release, the schema will be initialized from the DBIC schema classes, not big SQL scripts as is the status quo. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 23500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23500&action=edit Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7365 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23500|0 |1 is obsolete| | --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 23767 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23767&action=edit Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #23767|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 23778 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23778&action=edit Bug 11155: remove old PostgreSQL schema and MARC framework scripts This patch removes the legacy Pg schema and MARC framework scripts as they're out of date. They will be replaced by use of DBIx::Class to deploy the schema. Loading the sample data and settings will be accomplished either by making the current scripts in installer/data/mysql DBMS-independent (or, at least, able to be processed by both MySQL and Pg), converting them to flat text files and writing code to load them, or a combination of the two approaches. To test: [1] Verify that installer/data/Pg is removed. There is some code in C4::Installer that refers to that directory, but it cannot be reached through normal means. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11155 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Patch pushed to 3.14.x, will be in 3.14.2. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org