[Bug 15932] New: Moving Authorities actions into a drop-down menu
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Bug ID: 15932 Summary: Moving Authorities actions into a drop-down menu Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org Created attachment 48420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48420&action=edit auth search results To reproduce: Do an authority search on authorities-home.pl Notice actions (Edit, Merge, Delete) can be styled as a drop down menu (see Bug 15830, Bug 13778), see attachment -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48520&action=edit Bug 15932: Moving Authorities actions into a drop-down menu To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48520|0 |1 is obsolete| | --- Comment #2 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 48534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48534&action=edit Bug 15932: Moving Authorities actions into a drop-down menu To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi, I think the menu is a good idea, but the datatable doesn't work here. If you have more than 20 results, the authority search has its own paging - you won't be able to use the paging from the datatables for your results. Also - this change is not part of the bug description! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48534|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48568&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed ddatatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48568|0 |1 is obsolete| | --- Comment #5 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48717&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48717|0 |1 is obsolete| | --- Comment #6 from Nicole C. Engard <nengard@gmail.com> --- Created attachment 48823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48823&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- QA comment: There is a wrong behavior: Click on Actions > Delete > Cancel => The scrollbar goes to the top -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48823|0 |1 is obsolete| | --- Comment #8 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 48909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48909&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- Was this change intentional? It's a regression from Bug 15927. + [% UNLESS ( loop.odd ) %] + <tr data-authid="[% resul.authid %]" class="highlight"> + [% ELSE %] + <tr data-authid="[% resul.authid %]"> + [% END %] -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48909|0 |1 is obsolete| | --- Comment #10 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49062&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 49062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49062 Bug 15932: Moving Authorities actions into a drop-down menu Review of attachment 49062: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15932&attachment=49062) ----------------------------------------------------------------- I don't think comment #9 was dealt with. ::: koha-tmpl/intranet-tmpl/prog/en/modules/authorities/searchresultlist.tt @@ -73,5 @@
- <th> </th> - [% END %] - </tr> -[% FOREACH resul IN result %] - <tr data-authid="[% resul.authid %]">
I think you should have kept this <tr> line. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49062|0 |1 is obsolete| | --- Comment #12 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 49407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49407&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 --- Comment #13 from Marc Véron <veron@veron.ch> --- Created attachment 49432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49432&action=edit Drop down very wide The drop down list is very wide, is that intended? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 --- Comment #14 from Aleisha Amohia <aleishaamohia@hotmail.com> --- (In reply to Marc Véron from comment #13)
Created attachment 49432 [details] Drop down very wide
The drop down list is very wide, is that intended?
Not intended, and not really sure why it's happening. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 --- Comment #15 from Marc Véron <veron@veron.ch> --- It has the same with as on /cgi-bin/koha/acqui/invoices.pl Seems to be related to the class dropdown-menu ( min-width: 160px; ) Signing off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49407|0 |1 is obsolete| | --- Comment #16 from Marc Véron <veron@veron.ch> --- Created attachment 49436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49436&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #49436|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 49464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49464&action=edit Bug 15932: Moving Authorities actions into a drop-down menu Edit: Removed datatables stuff and fixed merge conflict Edit: Removed code from Comment 9 (no it wasn't intentional) Edit: Putting <tr> line back To test: 1) Go to Authorities and do an authority search (authorities-home.pl) 2) Confirm that the options (Edit, Merge, Delete) are there and behave as expected. EDIT: 3) Click Delete then Cancel, confirm page does not scroll to the top Sponsored-by: Catalyst IT Signed-off-by: Frédéric Demians <f.demians@tamil.fr> Signed-off-by: Nicole C Engard <nengard@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15932 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m Status|Passed QA |Pushed to Master --- Comment #18 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org