[Bug 19719] New: Add a ‘Collection’ column in the patron loans data table.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Bug ID: 19719 Summary: Add a ‘Collection’ column in the patron loans data table. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jesse@bywatersolutions.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org 1 - Add the Collection code (ccode) to the issues table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #1 from Jesse Maseto <jesse@bywatersolutions.com> --- Created attachment 72773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72773&action=edit Bug 19719 - Add a ‘Collection’ column in the patron loans data table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #2 from Jesse Maseto <jesse@bywatersolutions.com> --- TEST: 1. Check out a few items to patron. 2. View check outs on patron account in staff client. 3. Collection code is not present. 4. Apply patch 5. Notice that not Collection code is visible while viewing check outs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt@gmail.com, | |kyle.m.hall@gmail.com Component|Architecture, internals, |Circulation |and plumbing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Edie Discher <edischer@cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |edischer@cityoffargo.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #3 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 72829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72829&action=edit Bug 19719 - Add a ‘Collection’ column in the patron loans data table. Signed-off-by: Severine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |severine.queune@bulac.fr --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Column correctly appears on both "Checkout" and "Details" tabs on patron account. It is correctly hidden if "collection_code" box are checked on Column configuration > Circulation > id=issues-table and Column configuration > Patrons > id=issues-table. Thanks Kyle and Jesse ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Maksim Sen <maksim.sen@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maksim.sen@inlibro.com --- Comment #5 from Maksim Sen <maksim.sen@inlibro.com> --- The patch works correctly but when I try to sign off the patch I get this error message. /usr/local/bin/git-bz:1834: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal obsoleted = (initial_description == patch.description) Traceback (most recent call last): File "/usr/local/bin/git-bz", line 2632, in <module> do_attach(*args) File "/usr/local/bin/git-bz", line 1998, in do_attach attach_commits(bug, commits, edit_comments=global_options.edit) File "/usr/local/bin/git-bz", line 1913, in attach_commits description, body, obsoletes, statuses, patch_complexities, depends = edit_attachment_comment(bug, commit.subject, body) File "/usr/local/bin/git-bz", line 1866, in edit_attachment_comment lines = edit_template(template.getvalue()) File "/usr/lib/python2.7/StringIO.py", line 271, in getvalue self.buf += ''.join(self.buflist) UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 18: ordinal not in range(128) I didn't get this message when signing off other bugs. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|Add a ‘Collection’ column |Add a new column for |in the patron loans data |collection in the patron |table. |checkouts data table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the issue is weird characters (quote in this case) in the patch message. UnicodeEncodeError: 'latin-1' codec can't encode character u'\u2018' in position 26: ordinal not in range(256) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72773|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72829|Bug 19719 - Add a |Bug 19719 - Add a description|‘Collection’ column in the |Collection column in the |patron loans data table. |patron loans data table. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73510&action=edit Bug 19719: Add new column for collection in the patron checkouts data tables This makes the collection visible in the checkouts table on the details and issues tab in the patron account in staff. TEST: 1. Check out a few items to patron. 2. View check outs on patron account in staff client. 3. Collection code is not present. 4. Apply patch 5. Notice that not Collection code is visible while viewing check outs. Signed-off-by: Severine QUEUNE <severine.queune@bulac.fr> Signed-off by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 73511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73511&action=edit Bug 19719: (follow-up) Show description instead of code This follow-up changes the display from collection code to description, following the existing pattern for location. To test: - Repeat test plan from first patch - Verfiy now the collection descrption shows - Change column setting in administration - Verify they work as expected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72829|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jesse, a few small things: - please include a description and the test plan in your commit message - please stick to latin-1 :) I've added a follow-up changing the display from collection code to collection name to keep things consistent. Asking for a sign-off for the follow-up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73510|0 |1 is obsolete| | --- Comment #10 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74538&action=edit Bug 19719: Add new column for collection in the patron checkouts data tables This makes the collection visible in the checkouts table on the details and issues tab in the patron account in staff. TEST: 1. Check out a few items to patron. 2. View check outs on patron account in staff client. 3. Collection code is not present. 4. Apply patch 5. Notice that not Collection code is visible while viewing check outs. Signed-off-by: Severine QUEUNE <severine.queune@bulac.fr> Signed-off by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73511|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 74539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74539&action=edit Bug 19719: (follow-up) Show description instead of code This follow-up changes the display from collection code to description, following the existing pattern for location. To test: - Repeat test plan from first patch - Verfiy now the collection descrption shows - Change column setting in administration - Verify they work as expected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #12 from Séverine Queune <severine.queune@bulac.fr> --- Displaying is correct, depending on the Column settings. Ok for me ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Do we really want to display this column for all installations? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We could display for new installations and hide on update? Not sure about the db structure there, have to take a closer look. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- Update the table's column configuration to initially hide the column? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 76199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76199&action=edit Bug 19719: (follow-up) Add database update to keep collection column hidden For existing installations we want to keep the current behaviour. This patch adds the column configuration to hide the collection column from the details and checkouts tabs until toggled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Proposed a database update :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 74539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74539 Bug 19719: (follow-up) Show description instead of code Review of attachment 74539: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=19719&attachment=74539) ----------------------------------------------------------------- ::: svc/checkouts @@ +158,5 @@
} + my $collection; + if ( $c->{collection} ) { + my $av = Koha::AuthorisedValues->search({ category => 'CCODE', authorised_value => $c->{collection} }); + $collection = $av->count ? $av->next->lib : '';
Shouldn't we check that items.ccode is linked to the authorized value list CCODE ? We could imagine that in the MARC framework, the item subfield linked to items.ccode is configured to use another AV list (or no AV list at all). If the item subfield is not linked to an AV list and contains free text, it is not displayed. I think that's a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #19 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Julian Maurice from comment #18)
If the item subfield is not linked to an AV list and contains free text, it is not displayed. I think that's a problem.
The same thing is done with items.location (AV list LOC), so passing QA for now to keep consistency. If it has to be fixed, we can fix them both in another bug. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74538|0 |1 is obsolete| | --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77559&action=edit Bug 19719: Add new column for collection in the patron checkouts data tables This makes the collection visible in the checkouts table on the details and issues tab in the patron account in staff. TEST: 1. Check out a few items to patron. 2. View check outs on patron account in staff client. 3. Collection code is not present. 4. Apply patch 5. Notice that not Collection code is visible while viewing check outs. Signed-off-by: Severine QUEUNE <severine.queune@bulac.fr> Signed-off by: Maksim Sen <maksim.sen@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74539|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77560&action=edit Bug 19719: (follow-up) Show description instead of code This follow-up changes the display from collection code to description, following the existing pattern for location. To test: - Repeat test plan from first patch - Verfiy now the collection descrption shows - Change column setting in administration - Verify they work as expected Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76199|0 |1 is obsolete| | --- Comment #22 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 77561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77561&action=edit Bug 19719: (follow-up) Add database update to keep collection column hidden For existing installations we want to keep the current behaviour. This patch adds the column configuration to hide the collection column from the details and checkouts tabs until toggled. Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21175 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21175 [Bug 21175] Handle locations and collections with no matching authorised value in patron checkouts table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #23 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize@ptfs-europe | |.com --- Comment #24 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, this will not be backported to 18.05.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19719 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23408 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23408 [Bug 23408] Relatives' checkout table columns are not configured properly -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org