[Bug 31354] New: Clarify options for 'Change messaging preferences to default for this category?' popup
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Bug ID: 31354 Summary: Clarify options for 'Change messaging preferences to default for this category?' popup Change sponsored?: --- Product: Koha Version: 21.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: sbrown@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The options for the 'Change messaging preferences to default for this category?' popup that appears when editing a patron's category are Cancel and OK, but I think No instead of Cancel and Yes instead of OK would be clearer. A library could reasonably think that Cancel refers to cancelling the change in category, and No would make it clearer that refers to the preferences only. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|21.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- To make this language more clear I think we should use a modal popup instead of a JS alert. +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #2 from Sam Lau <samalau@gmail.com> --- Created attachment 168480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168480&action=edit Bug 31354: Use modal popup for messaging preferences when editing a patron's category. To test: 1) In Administration->Patron categories, edit the 'Home Bound' category and select every messaging preferences. 2) Edit the 'Patron' category and select email for the 'Item due' messaging pref. 3) Visit a patrons page from any category except Homebound. Keep note of their messaging preferences (will probably just be none) 4) Edit this patron and change their category to 'Homebound'. You should be greeted with a modal that asks if you want to "Change messaging preferences to default for this category?". Select yes. Save changes on the edit form 5) In the details page, note the messaging preferences were set to the defualt for the Homebound category (all selected) 6) Edit patron again, this time change their category to 'Patron'. 7) When the modal pops up, select no. Save the edit form. 8) In details page, the messaging prefs should not have changed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |samalau@gmail.com Assignee|koha-bugs@lists.koha-commun |samalau@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #3 from Sam Lau <samalau@gmail.com> --- Created attachment 168482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168482&action=edit Bug 31354: Keep same functionality as before -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168480|0 |1 is obsolete| | Attachment #168482|0 |1 is obsolete| | --- Comment #4 from Sam Lau <samalau@gmail.com> --- Created attachment 168484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168484&action=edit Bug 31354: Use modal popup for messaging preferences when editing a patron's category. To test: 1) In Administration->Patron categories, edit the 'Home Bound' category and select every messaging preferences. 2) Edit the 'Patron' category and select email for the 'Item due' messaging pref. 3) Visit a patrons page from any category except Homebound. Keep note of their messaging preferences (will probably just be none) 4) Edit this patron and change their category to 'Homebound'. You should be greeted with a modal that asks if you want to "Change messaging preferences to default for this category?". Select yes. Save changes on the edit form 5) In the details page, note the messaging preferences were set to the defualt for the Homebound category (all selected) 6) Edit patron again, this time change their category to 'Patron'. 7) When the modal pops up, select no. Save the edit form. 8) In details page, the messaging prefs should not have changed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168484|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 168578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168578&action=edit Bug 31354: Use modal popup for messaging preferences when editing a patron's category. To test: 1) In Administration->Patron categories, edit the 'Home Bound' category and select every messaging preferences. 2) Edit the 'Patron' category and select email for the 'Item due' messaging pref. 3) Visit a patrons page from any category except Homebound. Keep note of their messaging preferences (will probably just be none) 4) Edit this patron and change their category to 'Homebound'. You should be greeted with a modal that asks if you want to "Change messaging preferences to default for this category?". Select yes. Save changes on the edit form 5) In the details page, note the messaging preferences were set to the defualt for the Homebound category (all selected) 6) Edit patron again, this time change their category to 'Patron'. 7) When the modal pops up, select no. Save the edit form. 8) In details page, the messaging prefs should not have changed. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #6 from David Nind <david@davidnind.com> --- Not related to this bug, but I identified this issue - Bug 37269 - Saving edits to a patron - error message clears or resets some fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #7 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171474&action=edit Something looks a bit weird here -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks for the effort to make this a real modal! The close button is however unstyled and I run into the following issues: 1) After running through the test plan I changed the patron category back to Homebound again 2) I then selected 'yes' in the modal. 3) Then I selected Homebound again. 4) Then I tried to select 'no' in the modal, but there was no reaction. 5) There was an alert with a spinner above the messaging preferences, though. Informing me on that message preference details were loaded. Could you try to reproduce this issue and then set it to Failed QA, or supply a patch for it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 171905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171905&action=edit Bug 31354: Adjust modal for Bootstrap5 changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> ---
Could you try to reproduce this issue and then set it to Failed QA, or supply a patch for it?
Paul can you try again now? I adjusted the modal for Bootstrap 5. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- Oh, something I noticed. I can only change the patron category once. -Change to HOMEBOUND, say yes to change the prefs. -Change to another patron category, no pop-op and prefs stay the same. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31354 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #12 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Lucas Gass (lukeg) from comment #11)
Oh, something I noticed. I can only change the patron category once.
-Change to HOMEBOUND, say yes to change the prefs. -Change to another patron category, no pop-op and prefs stay the same.
Please clarify or fix. Changing status to reflect need for feedback -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org